From: Joe Perches <joe@perches.com>
To: Ted Ts'o <tytso@mit.edu>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
libertas-dev@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next 00/20] Use pr_<level>
Date: Fri, 15 Jun 2012 16:37:16 -0700 [thread overview]
Message-ID: <1339803436.26435.4.camel@joe2Laptop> (raw)
In-Reply-To: <20120615225057.GD7363@thunk.org>
On Fri, 2012-06-15 at 18:50 -0400, Ted Ts'o wrote:
> On Fri, Jun 15, 2012 at 03:48:39AM -0700, Joe Perches wrote:
> > To tee up conversions of:
> > pr_<level>("%s: ...", ([truct netdevice *]foo)->name, ...)
> > to
> > netdev_<level>(foo, "...", ...)
>
> If the goal is to do the latter, why introduce needless patch churn
> now just to get to pr_<level>? Having a standardized netdev_<label>()
> adds real benefit that can be weighed against the cost of code churn.
> Why not just wait until the netdev_<level> infrastructure can be
> introduced? It will save effort on everybody's part.
Not really. This standardizes prefixes as is.
The newlines and such will still occur.
The git blame noise etc too.
The standardization via spatch will be
significantly easier this way. It's also
a far easier pattern to verify.
prev parent reply other threads:[~2012-06-15 23:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 5:53 [PATCH wireless-next 00/20] Use pr_<level> Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 01/20] adm8211: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 02/20] airo_cs: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 03/20] at76c50x-usb: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 04/20] atmel: atmel_cs: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 05/20] b43: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 06/20] b43legacy: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 07/20] hostap: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 08/20] ipw2x00: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 09/20] libertas: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 10/20] libertas_tf: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 11/20] mac80211_hwsim: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 12/20] mwl8k: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 13/20] orinoco: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 14/20] p54: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 15/20] prism54: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 16/20] ray_cs: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 17/20] rtl818x: " Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 18/20] ti: " Joe Perches
2012-06-15 8:36 ` Luciano Coelho
2012-06-15 10:42 ` Joe Perches
2012-06-15 5:53 ` [PATCH wireless-next 19/20] wl3501_cs: " Joe Perches
2012-06-15 5:54 ` [PATCH wireless-next 20/20] zd_usb: " Joe Perches
2012-06-15 7:36 ` [PATCH wireless-next 00/20] " Johannes Berg
2012-06-15 10:48 ` Joe Perches
2012-06-15 22:50 ` Ted Ts'o
2012-06-15 23:37 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339803436.26435.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=b43-dev@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).