From: Johannes Berg <johannes@sipsolutions.net>
To: "Goldenshtein, Victor" <victorg@ti.com>
Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
mcgrof@frijolero.org, zefir.kurtisi@neratec.com,
adrian.chadd@gmail.com, j@w1.fi, coelho@ti.com, assaf@ti.com,
yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org,
nbd@nbd.name, simon.wunderlich@s2003.tu-chemnitz.de
Subject: Re: [PATCH 0/7] nl/cfg/mac80211: add DFS master ability
Date: Mon, 18 Jun 2012 17:04:16 +0200 [thread overview]
Message-ID: <1340031856.4615.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAK80WHYDTiAYDD91RUE+V60iogEeKct2o9qLg7Y_iCZHjp+z9A@mail.gmail.com>
On Mon, 2012-06-18 at 18:02 +0300, Goldenshtein, Victor wrote:
> On Mon, Jun 18, 2012 at 5:59 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Mon, 2012-06-18 at 17:46 +0300, Victor Goldenshtein wrote:
> >> In continuation to proposed RFC, this patch set (with hostap patch
> >> series) adds support for DFS (Dynamic Frequency Selection) according
> >> 802.11h.
> >
> > Please fix coding style in this patchset first. There are various places
> > with bad indentation etc.
> >
> > johannes
> >
>
> I have checked all patches with checkpatch, zero warnings.
> Maybe only the cover letter has some style problems?
checkpatch isn't a replacement for reviewing code :-)
try --strict anyway
e.g.
+ if ((!(chan->flags & IEEE80211_CHAN_RADAR) || !dfs_supported) &&
+ ((chan->flags & (IEEE80211_CHAN_NO_IBSS | IEEE80211_CHAN_RADAR |
+ IEEE80211_CHAN_PASSIVE_SCAN))))
goto fail;
johannes
next prev parent reply other threads:[~2012-06-18 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 14:46 [PATCH 0/7] nl/cfg/mac80211: add DFS master ability Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 1/7] nl80211/cfg80211: add radar detection command/event Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 2/7] mac80211: " Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 3/7] nl80211/cfg80211: add ability to enable TX on op-channel Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 4/7] mac80211: " Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 5/7] nl80211/cfg80211: add ap channel switch command/event Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 6/7] mac80211: " Victor Goldenshtein
2012-06-18 14:46 ` [PATCH 7/7] mac80211: add DFS support to monitor interface Victor Goldenshtein
2012-06-19 6:44 ` Kalle Valo
2012-06-19 6:57 ` Luciano Coelho
2012-06-20 6:09 ` Kalle Valo
2012-06-19 8:42 ` Goldenshtein, Victor
2012-06-18 14:59 ` [PATCH 0/7] nl/cfg/mac80211: add DFS master ability Johannes Berg
2012-06-18 15:02 ` Goldenshtein, Victor
2012-06-18 15:04 ` Johannes Berg [this message]
2012-06-20 10:34 ` Zefir Kurtisi
2012-06-20 10:47 ` Goldenshtein, Victor
2012-06-20 10:49 ` Johannes Berg
2012-06-20 11:02 ` Goldenshtein, Victor
2012-06-20 12:03 ` Luciano Coelho
2012-06-20 12:07 ` Luciano Coelho
2012-06-20 16:44 ` Goldenshtein, Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340031856.4615.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian.chadd@gmail.com \
--cc=adrian@freebsd.org \
--cc=assaf@ti.com \
--cc=coelho@ti.com \
--cc=igalc@ti.com \
--cc=j@w1.fi \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
--cc=nbd@nbd.name \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=victorg@ti.com \
--cc=yoni.divinsky@ti.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).