From: Johannes Berg <johannes@sipsolutions.net>
To: Victor Goldenshtein <victorg@ti.com>
Cc: linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
mcgrof@frijolero.org, zefir.kurtisi@neratec.com,
adrian.chadd@gmail.com, j@w1.fi, coelho@ti.com, assaf@ti.com,
yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org,
nbd@nbd.name, simon.wunderlich@s2003.tu-chemnitz.de
Subject: Re: [PATCH v2 5/7] nl80211/cfg80211: add ap channel switch command/event
Date: Wed, 20 Jun 2012 10:47:52 +0200 [thread overview]
Message-ID: <1340182072.4655.41.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340111463-4554-5-git-send-email-victorg@ti.com>
On Tue, 2012-06-19 at 16:11 +0300, Victor Goldenshtein wrote:
> @@ -565,6 +565,15 @@
> * the time passed sines the beginning of the CAC is less than
interestingly now I see a typo in the previous patch: "sines"?
> * @NL80211_FEATURE_DFS: Radar detection is supported in the HW/driver.
> + * @NL80211_FEATURE_AP_CH_SWITCH: This driver supports AP channel switch.
what point is there in separating these flags?
> + int (*ap_channel_switch)(struct wiphy *wiphy, struct net_device *dev,
> + u32 count, bool block_tx,
> + bool post_switch_block_tx,
> + struct ieee80211_channel *new_ch);
If mac80211 needs a struct, why not have one here already rather than
all the parameters?
johannes
next prev parent reply other threads:[~2012-06-20 8:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 13:10 [PATCH v2 1/7] nl80211/cfg80211: add radar detection command/event Victor Goldenshtein
2012-06-19 13:10 ` [PATCH v2 2/7] mac80211: " Victor Goldenshtein
2012-06-20 8:40 ` Johannes Berg
2012-06-19 13:10 ` [PATCH v2 3/7] nl80211/cfg80211: add ability to enable TX on op-channel Victor Goldenshtein
2012-06-20 8:44 ` Johannes Berg
2012-06-20 8:46 ` Johannes Berg
2012-06-20 11:53 ` Zefir Kurtisi
2012-06-20 11:57 ` Johannes Berg
2012-06-20 12:58 ` Zefir Kurtisi
2012-06-20 13:12 ` Johannes Berg
2012-06-20 13:32 ` Goldenshtein, Victor
2012-06-20 14:18 ` Johannes Berg
2012-06-20 13:38 ` Zefir Kurtisi
2012-06-20 14:19 ` Johannes Berg
2012-06-20 15:06 ` Goldenshtein, Victor
2012-06-20 14:34 ` Goldenshtein, Victor
2012-06-19 13:11 ` [PATCH v2 4/7] mac80211: " Victor Goldenshtein
2012-06-19 13:11 ` [PATCH v2 5/7] nl80211/cfg80211: add ap channel switch command/event Victor Goldenshtein
2012-06-20 8:47 ` Johannes Berg [this message]
2012-06-20 17:17 ` Goldenshtein, Victor
2012-06-20 17:39 ` Johannes Berg
2012-06-21 5:35 ` Goldenshtein, Victor
2012-06-21 7:06 ` Johannes Berg
2012-06-19 13:11 ` [PATCH v2 6/7] mac80211: " Victor Goldenshtein
2012-06-20 8:48 ` Johannes Berg
2012-06-19 13:11 ` [PATCH v2 7/7] mac80211: add DFS support to monitor interface Victor Goldenshtein
2012-06-20 8:49 ` Johannes Berg
2012-06-20 16:50 ` Goldenshtein, Victor
2012-06-20 8:40 ` [PATCH v2 1/7] nl80211/cfg80211: add radar detection command/event Johannes Berg
2012-06-20 12:22 ` Zefir Kurtisi
2012-06-20 12:29 ` Johannes Berg
2012-06-20 16:42 ` Goldenshtein, Victor
2012-06-20 17:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340182072.4655.41.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian.chadd@gmail.com \
--cc=adrian@freebsd.org \
--cc=assaf@ti.com \
--cc=coelho@ti.com \
--cc=igalc@ti.com \
--cc=j@w1.fi \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
--cc=nbd@nbd.name \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=victorg@ti.com \
--cc=yoni.divinsky@ti.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).