Re: [PATCH v2 5/7] nl80211/cfg80211: add ap channel switch command/event

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2012-06-20 at 20:17 +0300, Goldenshtein, Victor wrote:

> >>   * @NL80211_FEATURE_DFS: Radar detection is supported in the HW/driver.
> >> + * @NL80211_FEATURE_AP_CH_SWITCH: This driver supports AP channel switch.
> >
> > what point is there in separating these flags?
> >
> 
> One may support AP channel switch without DFS support, i.e. switching
> to non DFS channels.

Oh, right, makes sense, though I'd enforce that DFS must support
chanswitch?

> >
> >> +     int     (*ap_channel_switch)(struct wiphy *wiphy, struct net_device *dev,
> >> +                                  u32 count, bool block_tx,
> >> +                                  bool post_switch_block_tx,
> >> +                                  struct ieee80211_channel *new_ch);
> >
> > If mac80211 needs a struct, why not have one here already rather than
> > all the parameters?
> >
> 
> OK, it I will just require additional mac patch before current one, I
> will split the "mac80211: add ap channel switch command/event".

Well, you'll have to move the struct definition into cfg80211 and into
this patch I think.

johannes