linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v2 7/7] mac80211: reuse channels for channel context
Date: Thu, 21 Jun 2012 15:26:27 +0200	[thread overview]
Message-ID: <1340285187.4489.25.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340280216-18807-8-git-send-email-michal.kazior@tieto.com>

On Thu, 2012-06-21 at 14:03 +0200, Michal Kazior wrote:

> +		if (!ieee80211_channel_types_are_compatible(ctx->conf.channel_type,
> +							    channel_type,
> +							    &compat_type))
> +			continue;
> +		if (ctx->conf.channel_type != compat_type) {
> +			ctx->conf.channel_type = compat_type;
> +			drv_change_chantype(local, ctx);
> +		}

Maybe somehow there's a need to also keep track of the desired channel
type per vif so it can be recalculated when a vif is removed, not just
when one is added?

johannes


  reply	other threads:[~2012-06-21 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 12:03 [RFC v2] initial channel context implementation Michal Kazior
2012-06-21 12:03 ` [RFC v2 1/7] mac80211: introduce channel contexts skeleton code Michal Kazior
2012-06-21 13:24   ` Johannes Berg
2012-06-25  6:52     ` Michal Kazior
2012-06-21 12:03 ` [RFC v2 2/7] mac80211: introduce new ieee80211_ops Michal Kazior
2012-06-21 12:03 ` [RFC v2 3/7] mac80211: add drv_* wrappers for channel contexts Michal Kazior
2012-06-21 12:03 ` [RFC v2 4/7] mac80211: add chanctx tracing Michal Kazior
2012-06-21 12:03 ` [RFC v2 5/7] mac80211: use channel context notifications Michal Kazior
2012-06-21 12:03 ` [RFC v2 6/7] mac80211: refactor set_channel_type Michal Kazior
2012-06-21 12:03 ` [RFC v2 7/7] mac80211: reuse channels for channel context Michal Kazior
2012-06-21 13:26   ` Johannes Berg [this message]
2012-06-25  6:54     ` Michal Kazior
2012-06-21 13:19 ` [RFC v2] initial channel context implementation Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340285187.4489.25.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).