From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging
Date: Fri, 22 Jun 2012 07:49:09 -0700 [thread overview]
Message-ID: <1340376549.31821.19.camel@joe2Laptop> (raw)
In-Reply-To: <1340376203.4491.29.camel@jlt3.sipsolutions.net>
On Fri, 2012-06-22 at 16:43 +0200, Johannes Berg wrote:
> > Using a single style _with_ a newline limits defects and
> > limits the likely misuse in other styles.
>
> I'd rather have double newlines once a while than missing ones. I've
> seen a lot of bugs with missing newlines, which is rather annoying.
Yeah, I have too.
It's because people add macros that add terminating
newlines and there's no style consistency.
I think you should _not_ add more macros that promote
this inconsistency.
usb's uses of err/warn/info/dbg are going away.
These should too.
next prev parent reply other threads:[~2012-06-22 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 13:14 mac80211 logging/tracing Johannes Berg
2012-06-22 13:14 ` [PATCH 1/6] mac80211: remove TKIP debug Johannes Berg
2012-06-22 13:14 ` [PATCH 2/6] mac80211: two small verbose debug cleanups Johannes Berg
2012-06-22 13:14 ` [PATCH 3/6] mac80211: pass sdata to some RX functions Johannes Berg
2012-06-22 13:14 ` [PATCH 4/6] mac80211: clean up debugging Johannes Berg
2012-06-22 14:37 ` Joe Perches
2012-06-22 14:43 ` Johannes Berg
2012-06-22 14:49 ` Joe Perches [this message]
2012-06-22 13:14 ` [PATCH 5/6] mac80211: rename driver-trace file Johannes Berg
2012-06-22 13:14 ` [PATCH 6/6] mac80211: trace debug messages Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2012-06-22 17:18 [PATCH v2 0/6] mac80211 debugging Johannes Berg
2012-06-22 17:18 ` [PATCH 4/6] mac80211: clean up debugging Johannes Berg
2012-06-23 8:02 ` Joe Perches
2012-06-23 13:04 ` Johannes Berg
2012-06-23 15:40 ` Joe Perches
2012-06-24 9:30 ` Johannes Berg
2012-06-25 21:29 ` Jason Baron
2012-06-26 5:23 ` Joe Perches
2012-06-23 16:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340376549.31821.19.camel@joe2Laptop \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox