From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
Jim Cromie <jim.cromie@gmail.com>,
Jason Baron <jbaron@redhat.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: dynamic debug
Date: Fri, 22 Jun 2012 17:36:34 +0200 [thread overview]
Message-ID: <1340379394.4491.37.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340379153.31821.21.camel@joe2Laptop>
On Fri, 2012-06-22 at 08:32 -0700, Joe Perches wrote:
> > Are you sure? It doesn't really seem to work ...
> >
> > #if defined(CONFIG_DYNAMIC_DEBUG)
> > /* dynamic_pr_debug() uses pr_fmt() internally so we don't need it here */
> > #define pr_debug(fmt, ...) \
> > dynamic_pr_debug(fmt, ##__VA_ARGS__)
> > #elif defined(DEBUG)
> > #define pr_debug(fmt, ...) \
> > printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> >
> >
> >
> > So basically, if you have CONFIG_DYNAMIC_DEBUG, you *still* need to
> > enable it with the dynamic debug framework, right?
>
> No.
>
> In dynamic_debug.h, there's a mechanism to enable all
> dynamic_pr_debug lines when DEBUG is #defined
>
> #if defined DEBUG
> #define _DPRINTK_FLAGS_DEFAULT _DPRINTK_FLAGS_PRINT
> #else
> #define _DPRINTK_FLAGS_DEFAULT 0
> #endif
Hah. Too much indirection I guess.
Thanks.
I'll respin my patches.
johannes
next prev parent reply other threads:[~2012-06-22 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 12:23 dynamic debug Johannes Berg
2012-06-22 14:26 ` Joe Perches
2012-06-22 14:34 ` Johannes Berg
2012-06-22 14:41 ` Joe Perches
2012-06-22 14:48 ` Johannes Berg
2012-06-22 15:21 ` Johannes Berg
2012-06-22 15:32 ` Joe Perches
2012-06-22 15:36 ` Johannes Berg [this message]
2012-06-22 17:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340379394.4491.37.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).