From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Jim Cromie <jim.cromie@gmail.com>,
Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging
Date: Sat, 23 Jun 2012 08:40:44 -0700 [thread overview]
Message-ID: <1340466044.7758.4.camel@joe2Laptop> (raw)
In-Reply-To: <1340456697.4636.1.camel@jlt3.sipsolutions.net>
On Sat, 2012-06-23 at 15:04 +0200, Johannes Berg wrote:
> On Sat, 2012-06-23 at 01:02 -0700, Joe Perches wrote:
>
> > I think all the Kconfig debugging options aren't
> > particularly useful.
> >
> > I think you should use a level/mask module debug
> > variable to enable these instead of appearing to try
> > to minimize the size of the objects via individual
> > Kconfig options.
> >
> > I think it'd be better to enable them all the time
> > (or not at all when !DEBUG) and select them for output
> > via the debug level.
>
> I agree, but I don't want to switch twice. Once pr_debug() has dynamic
> sub-selector capabilities, I'll use it here.
>
> FWIW, I would definitely prefer named rather than bitmap selectors :-)
(Added Jason and Jim)
Given it's a debug-only facility, I think bitmap
selectors sufficient, Maybe adding an external
utility to map names to bits would be enough to
not need that feature in the kernel.
next prev parent reply other threads:[~2012-06-23 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 17:18 [PATCH v2 0/6] mac80211 debugging Johannes Berg
2012-06-22 17:18 ` [PATCH 1/6] mac80211: remove TKIP debug Johannes Berg
2012-06-22 17:18 ` [PATCH 2/6] mac80211: two small verbose debug cleanups Johannes Berg
2012-06-22 17:18 ` [PATCH 3/6] mac80211: pass sdata to some RX functions Johannes Berg
2012-06-22 17:18 ` [PATCH 4/6] mac80211: clean up debugging Johannes Berg
2012-06-23 8:02 ` Joe Perches
2012-06-23 13:04 ` Johannes Berg
2012-06-23 15:40 ` Joe Perches [this message]
2012-06-24 9:30 ` Johannes Berg
2012-06-25 21:29 ` Jason Baron
2012-06-26 5:23 ` Joe Perches
2012-06-23 16:03 ` Joe Perches
2012-06-22 17:18 ` [PATCH 5/6] mac80211: rename driver-trace file Johannes Berg
2012-06-22 17:18 ` [PATCH 6/6] mac80211: trace debug messages Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2012-06-22 13:14 mac80211 logging/tracing Johannes Berg
2012-06-22 13:14 ` [PATCH 4/6] mac80211: clean up debugging Johannes Berg
2012-06-22 14:37 ` Joe Perches
2012-06-22 14:43 ` Johannes Berg
2012-06-22 14:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340466044.7758.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).