From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFCv2 10/13] cfg80211: set initial monitor channel
Date: Mon, 25 Jun 2012 09:41:31 +0200 [thread overview]
Message-ID: <1340610091.4589.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FE815FC.8040702@tieto.com>
On Mon, 2012-06-25 at 09:40 +0200, Michal Kazior wrote:
> Johannes Berg wrote:
> > On Mon, 2012-06-25 at 08:57 +0200, Michal Kazior wrote:
> >> Johannes Berg wrote:
> >>> On Wed, 2012-06-20 at 08:14 +0200, Michal Kazior wrote:
> >>>> Implements behaviour seen in mac80211. A running
> >>>> monitor always has a channel - even before
> >>>> .set_channel. This way we won't break current
> >>>> behaviour.
> >>>
> >>> I'm a little doubtful about this. Currently, mac80211 will keep the
> >>> channel if you set it on say wlan0, your monitor iface gets the same
> >>> channel. Then if you remove wlan0, you still have the same channel, but
> >>> it seems here this is different now? I'm not sure it matters much, but
> >>> it's worth thinking about? Or am I totally misunderstanding this now?
> >>
> >> Right. It's not the exact same behaviour. It only guarantees a channel
> >> is always set in monitor mode. We could maybe set the last
> >> monitor-mode-channel seen when starting up monitor-mode again. Would
> >> that be okay?
> >
> > Yeah I think that's probably fine. Come to think of it, without that
> > change you always have a channel pointer, but it's not guaranteed to be
> > programmed into the device? Maybe I'm confused.
>
> The rdev->monitor_channel is set to NULL when monitor mode is disabled
> (see `cfg80211: track monitor channel`).
>
> When monitor mode is started the hardware is programmed (and pointer
> set) to the first channel found in supported bands (see `cfg80211: set
> initial monitor channel`).
Ah ok, fair enough. I don't mind this, let's see if anyone complains? :)
johannes
next prev parent reply other threads:[~2012-06-25 7:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 6:14 [RFCv2] respect channels in iface combinations Michal Kazior
2012-06-20 6:14 ` [RFCv2 01/13] cfg80211: introduce cfg80211_stop_ap Michal Kazior
2012-06-20 6:14 ` [RFCv2 02/13] cfg80211: .stop_ap when interface is going down Michal Kazior
2012-06-20 6:14 ` [RFCv2 03/13] cfg80211: add channel tracking for AP and mesh Michal Kazior
2012-06-20 8:18 ` Johannes Berg
2012-06-20 9:03 ` Michal Kazior
2012-06-20 9:09 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 04/13] cfg80211: track ibss fixed channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 05/13] cfg80211: introduce cfg80211_get_chan_state Michal Kazior
2012-06-20 8:19 ` Johannes Berg
2012-06-20 9:11 ` Michal Kazior
2012-06-20 9:13 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 06/13] cfg80211: track monitor interfaces count Michal Kazior
2012-06-21 14:55 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 07/13] mac80211: refactor virtual monitor code Michal Kazior
2012-06-20 6:14 ` [RFCv2 08/13] cfg80211: refuse to .set_monitor_channel when non-monitors are present Michal Kazior
2012-06-20 6:14 ` [RFCv2 09/13] cfg80211: track monitor channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 10/13] cfg80211: set initial " Michal Kazior
2012-06-21 14:57 ` Johannes Berg
2012-06-25 6:57 ` Michal Kazior
2012-06-25 7:28 ` Johannes Berg
2012-06-25 7:40 ` Michal Kazior
2012-06-25 7:41 ` Johannes Berg [this message]
2012-06-20 6:14 ` [RFCv2 11/13] cfg80211/mac80211: remove .get_channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 12/13] cfg80211: add channel checking for iface combinations Michal Kazior
2012-06-21 15:03 ` Johannes Berg
2012-06-25 7:00 ` Michal Kazior
2012-06-20 6:14 ` [RFCv2 13/13] cfg80211: respect iface combinations when starting operation Michal Kazior
2012-06-21 15:06 ` Johannes Berg
2012-06-25 7:05 ` Michal Kazior
2012-06-25 7:27 ` Johannes Berg
2012-06-20 8:23 ` [RFCv2] respect channels in iface combinations Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340610091.4589.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).