From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v3 11/13] cfg80211/mac80211: remove .get_channel
Date: Tue, 26 Jun 2012 15:22:06 +0200 [thread overview]
Message-ID: <1340716926.14634.32.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340713818-28549-12-git-send-email-michal.kazior@tieto.com>
On Tue, 2012-06-26 at 14:30 +0200, Michal Kazior wrote:
> +++ b/net/wireless/nl80211.c
> @@ -1588,17 +1588,11 @@ static int nl80211_send_iface(struct sk_buff *msg, u32 pid, u32 seq, int flags,
> (cfg80211_rdev_list_generation << 2)))
> goto nla_put_failure;
>
> - if (rdev->ops->get_channel) {
> - struct ieee80211_channel *chan;
> - enum nl80211_channel_type channel_type;
> -
> - chan = rdev->ops->get_channel(&rdev->wiphy, &channel_type);
> - if (chan &&
> - (nla_put_u32(msg, NL80211_ATTR_WIPHY_FREQ,
> - chan->center_freq) ||
> - nla_put_u32(msg, NL80211_ATTR_WIPHY_CHANNEL_TYPE,
> - channel_type)))
> - goto nla_put_failure;
> + if (rdev->monitor_channel) {
> + nla_put_u32(msg, NL80211_ATTR_WIPHY_FREQ,
> + rdev->monitor_channel->center_freq);
> + nla_put_u32(msg, NL80211_ATTR_WIPHY_CHANNEL_TYPE,
> + rdev->monitor_channel_type);
Tiny comment here -- you're removing nla_put error handling.
johannes
next prev parent reply other threads:[~2012-06-26 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 12:30 [RFC v3] respect channels in iface combinations Michal Kazior
2012-06-26 12:30 ` [RFC v3 01/13] cfg80211: introduce cfg80211_stop_ap Michal Kazior
2012-06-26 12:30 ` [RFC v3 02/13] cfg80211: .stop_ap when interface is going down Michal Kazior
2012-06-26 12:30 ` [RFC v3 03/13] cfg80211: add channel tracking for AP and mesh Michal Kazior
2012-06-26 12:30 ` [RFC v3 04/13] cfg80211: track ibss fixed channel Michal Kazior
2012-06-26 12:30 ` [RFC v3 05/13] cfg80211: introduce cfg80211_get_chan_state Michal Kazior
2012-06-26 12:30 ` [RFC v3 06/13] cfg80211: track monitor interfaces count Michal Kazior
2012-06-26 12:30 ` [RFC v3 07/13] mac80211: refactor virtual monitor code Michal Kazior
2012-06-26 12:30 ` [RFC v3 08/13] cfg80211: refuse to .set_monitor_channel when non-monitors are present Michal Kazior
2012-06-26 12:30 ` [RFC v3 09/13] cfg80211: track monitor channel Michal Kazior
2012-06-26 12:30 ` [RFC v3 10/13] cfg80211: set initial " Michal Kazior
2012-06-26 12:30 ` [RFC v3 11/13] cfg80211/mac80211: remove .get_channel Michal Kazior
2012-06-26 13:22 ` Johannes Berg [this message]
2012-06-26 12:30 ` [RFC v3 12/13] cfg80211: add channel checking for iface combinations Michal Kazior
2012-06-26 13:29 ` Johannes Berg
2012-06-26 13:44 ` Michal Kazior
2012-06-26 15:32 ` Johannes Berg
2012-06-26 12:30 ` [RFC v3 13/13] cfg80211: respect iface combinations when starting operation Michal Kazior
2012-06-26 13:31 ` [RFC v3] respect channels in iface combinations Johannes Berg
2012-06-26 14:05 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340716926.14634.32.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).