From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Arik Nemtsov <arik@wizery.com>, Eliad Peller <eliad@wizery.com>,
Luciano Coelho <coelho@ti.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wlcore: implement .flush callback
Date: Thu, 28 Jun 2012 20:48:12 +0200 [thread overview]
Message-ID: <1340909292.4491.51.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FECA5FB.30902@broadcom.com>
On Thu, 2012-06-28 at 20:44 +0200, Arend van Spriel wrote:
> >>> So not taking the drop flag into account? Any plan to change that?
> >>>
> >> yeah, good point...
> >> i guess we'll want to add support for the drop flag as well.
> >>
> >> Luca - you can either drop this patch, or apply it for now and i'll
> >> send another patch later on.
> >
> > Currently we drop all the packets if we can't flush them within a
> > reasonable time. We always do this right now. I think that's good
> > enough?
> >
>
> Hard to say as I am working mostly on your side of this API. However,
> the drop flag is part of the API so there is probably a reason for
> having it. Johannes?
The drop never actually used today... but we had plans to use it in some
cases I think.
johannes
next prev parent reply other threads:[~2012-06-28 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 16:09 [PATCH] wlcore: implement .flush callback Luciano Coelho
2012-06-28 5:52 ` Luciano Coelho
2012-06-28 11:07 ` Arend van Spriel
2012-06-28 11:25 ` Eliad Peller
2012-06-28 11:31 ` Arik Nemtsov
2012-06-28 18:44 ` Arend van Spriel
2012-06-28 18:48 ` Johannes Berg [this message]
2012-06-29 4:07 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340909292.4491.51.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=arik@wizery.com \
--cc=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).