Re: [PATCH] mac80211: always set in_reconfig=false on wakeup

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2012-07-02 at 15:08 +0300, Eliad Peller wrote:
> If the interfaces were removed just before a restart
> work was started, open_count will be 0, and most of
> the reconfig work will be skipped, including the
> resetting of local->in_reconfig to false.
> 
> Leaving local->inconfig = true will result in
> dropping any incoming packet.
> 
> Fix it by always setting local->in_reconfig = false
> (even if there are no active interfaces).
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
> this should go to 3.5

Also looks good, thanks

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

John, could you also pick this up?

johannes


>  net/mac80211/util.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 242ecde..e1b7c63 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -1411,10 +1411,10 @@ int ieee80211_reconfig(struct ieee80211_local *local)
>  		if (ieee80211_sdata_running(sdata))
>  			ieee80211_enable_keys(sdata);
>  
> + wake_up:
>  	local->in_reconfig = false;
>  	barrier();
>  
> - wake_up:
>  	/*
>  	 * Clear the WLAN_STA_BLOCK_BA flag so new aggregation
>  	 * sessions can be established after a resume.