From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: Kernel oops in __netif_schedule() for at76c50x-usb
Date: Mon, 02 Jul 2012 19:38:56 +0200 [thread overview]
Message-ID: <1341250736.19642.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4FF1C887.8090009@lwfinger.net> (sfid-20120702_181310_720968_3FE88ADC)
> > I'm not sure which fix is correct though. Should we have software QoS
> > queues for these drivers, but we'll never use them? Then this would
> > work:
> > http://p.sipsolutions.net/e015bf7db9a05887.txt
> >
> > Or we could change the enable code path. Hmm.
>
> That patch does prevent the oops. I was not able to make a connection with the
> device, but I just acquired it, and I'm not sure of its quality, or that of the
> driver.
I don't think that device works today -- IIRC it requires the BSSID
before authentication and that wasn't possible before the auth redesign.
> It does scan OK, and I think the patch is OK. I'll do more tests with
> b43legacy later as the machine with that iface is busy. I will also test b43 on
> the PPC using the open-source firmware.
>
> Although you may want to change the enable code path, some patch will be needed
> to prevent a regression in 3.5. If this is the one, you may add a "Tested-by"
> for me.
Thanks. Could you try this patch instead? I think it makes more sense.
http://p.sipsolutions.net/c3e9b814a409ca11.txt
johannes
next prev parent reply other threads:[~2012-07-02 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 15:21 Kernel oops in __netif_schedule() for at76c50x-usb Larry Finger
2012-07-02 15:31 ` Johannes Berg
2012-07-02 16:12 ` Larry Finger
2012-07-02 17:38 ` Johannes Berg [this message]
2012-07-02 22:50 ` Larry Finger
2012-07-04 9:46 ` Johannes Berg
2012-07-04 10:49 ` Johannes Berg
2012-07-04 10:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341250736.19642.22.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).