From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] compat-wireless: fix debugging in iwlwifi
Date: Tue, 03 Jul 2012 09:28:54 -0700 [thread overview]
Message-ID: <1341332934.2164.17.camel@joe2Laptop> (raw)
In-Reply-To: <1341332487.20124.7.camel@jlt3.sipsolutions.net>
On Tue, 2012-07-03 at 18:21 +0200, Johannes Berg wrote:
> On Tue, 2012-07-03 at 09:16 -0700, Luis R. Rodriguez wrote:
> > On Tue, Jul 3, 2012 at 8:47 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > > On Tue, Jul 3, 2012 at 6:28 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > >> From: Johannes Berg <johannes.berg@intel.com>
> > >>
> > >> As compat includes linux/device.h well before iwlwifi, the
> > >> definitions from there are used without DEBUG, but iwlwifi
> > >> defines DEBUG to get debug output. Use dev_printk instead
> > >> of dev_dbg to get debugging back.
> > >>
> > >> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > >
> > > Applied and pushed, thanks!
> >
> > On today's linux-next.git the dev_dbg() changed to dev_err(), I've
> > updated the patch to reflect this.
>
> Huh, sorry. Please drop this for now -- the patch to change it *from*
> dev_err *to* dev_dbg is only in my iwlwifi-next tree now.
And besides, the concept is wrong.
There's no reason to drop dynamic_debug support by
forcing output to KERN_DEBUG.
next prev parent reply other threads:[~2012-07-03 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:28 [PATCH] compat-wireless: fix debugging in iwlwifi Johannes Berg
2012-07-03 15:47 ` Luis R. Rodriguez
2012-07-03 16:16 ` Luis R. Rodriguez
2012-07-03 16:21 ` Johannes Berg
2012-07-03 16:28 ` Joe Perches [this message]
2012-07-03 16:47 ` Johannes Berg
2012-07-09 22:27 ` Luis R. Rodriguez
2012-07-03 16:30 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341332934.2164.17.camel@joe2Laptop \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox