From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/4] cfg80211: allow driver to implement HT capabilities per netdev
Date: Thu, 05 Jul 2012 09:42:20 +0200 [thread overview]
Message-ID: <1341474140.4455.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1341417530-9062-4-git-send-email-arik@wizery.com> (sfid-20120704_175902_427790_A0A1D81C)
On Wed, 2012-07-04 at 18:58 +0300, Arik Nemtsov wrote:
> void (*set_monitor_enabled)(struct wiphy *wiphy, bool enabled);
> + struct ieee80211_sta_ht_cap *(*get_ht_cap)(struct wiphy *wiphy,
> + struct net_device *dev,
> + enum ieee80211_band band);
Ok so ... I really don't like this whole concept to start with, but you
convinced me it was needed. This is just ugly though. Now you can
suddenly change the HT caps randomly at runtime? That's ... distressing
for userspace!
Is there any chance this can just be a pointer inside the wdev struct?
Then at least we can verify it in NETDEV_UP if you had invalid HT caps
originally, etc.
johannes
next prev parent reply other threads:[~2012-07-05 7:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 15:58 [RFC 0/4] allow setting HT capabilities per vif Arik Nemtsov
2012-07-04 15:58 ` [RFC 1/4] nl80211: accept optional netdev in send_wiphy Arik Nemtsov
2012-07-04 15:58 ` [RFC 2/4] cfg80211: support unused HT-cap-per-band configuration Arik Nemtsov
2012-07-05 7:39 ` Johannes Berg
2012-07-05 11:25 ` Arik Nemtsov
2012-07-06 6:59 ` Johannes Berg
2012-07-06 7:30 ` Arik Nemtsov
2012-07-06 7:34 ` Johannes Berg
2012-07-06 7:41 ` Arik Nemtsov
2012-07-09 9:31 ` Johannes Berg
2012-07-04 15:58 ` [RFC 3/4] cfg80211: allow driver to implement HT capabilities per netdev Arik Nemtsov
2012-07-05 7:42 ` Johannes Berg [this message]
2012-07-05 11:48 ` Arik Nemtsov
2012-07-05 13:33 ` Arik Nemtsov
2012-07-04 15:58 ` [RFC 4/4] mac80211: allow setting HT capabilities per vif Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341474140.4455.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).