From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Add transmit power control support (TPC)
Date: Mon, 09 Jul 2012 12:13:06 +0200 [thread overview]
Message-ID: <1341828786.4455.31.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1341826631.4455.24.camel@jlt3.sipsolutions.net> (sfid-20120709_113745_588565_D68A59A8)
On Mon, 2012-07-09 at 11:37 +0200, Johannes Berg wrote:
> > (6) restructure tx-path of all effected drivers
> > Restructure tx-path of all effected drivers to respect new TPC support in
> > mac80211. TPC support is added to mac80211 by restructuring of struct
> > ieee80211_tx_info. Therfore the tx-path of all effected drivers is modified
> > to receive struct sta from the stack and respect the new ieee80211_tx_info
> > struct. List of modified driver:
>
> again, separate these patches.
Oh and I don't mean split it per driver. Just split up the patch into
the logical API evolutions, like first removing the sta pointer and
introducing the tx_control struct. (Where, btw, you lost an important
comment about it being NULL along the way)
johannes
next prev parent reply other threads:[~2012-07-09 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 17:02 [PATCH] mac80211: Add transmit power control support (TPC) Thomas Huehn
2012-07-09 9:37 ` Johannes Berg
2012-07-09 9:55 ` thomas
2012-07-09 10:00 ` Johannes Berg
2012-07-09 10:13 ` Johannes Berg [this message]
2012-07-09 10:43 ` Thomas Huehn
2012-07-16 20:47 ` Hin-Tak Leung
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 19:18 Xose Vazquez Perez
2012-07-09 19:43 ` Felix Fietkau
2012-07-09 20:26 ` Xose Vazquez Perez
2012-07-09 21:22 ` Thomas Huehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341828786.4455.31.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).