[PATCH] compat: Fix setting $TARGET

[PATCH] compat: Fix setting $TARGET

[Ozan Çağlayan]

commit 61077651424add644401b927b52681a191bbd7f1 moved the list of
kernels above which broke the $TARGET substitutions in them.

Move the TARGET detection above of everything to fix this.

Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
---
 bin/get-compat-kernels |   33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/bin/get-compat-kernels b/bin/get-compat-kernels
index d80c0a7..99392b4 100755
--- a/bin/get-compat-kernels
+++ b/bin/get-compat-kernels
@@ -23,6 +23,23 @@ UNDERLINE="\033[02m"
 KERNELS=""
 KPATH="http://kernel.ubuntu.com/~kernel-ppa/mainline/"
 
+ARCH=$(uname -m)
+TARGET=""
+
+case $ARCH in
+	"x86_64")
+		TARGET="amd64"
+		;;
+	"i686")
+		TARGET="i386"
+		;;
+	*)
+		echo -e "Unsupported architecture"
+		exit
+		;;
+esac
+
+
 KERNELS="$KERNELS ${KPATH}/v2.6.24/linux-headers-2.6.24-020624_2.6.24-020624_all.deb"
 KERNELS="$KERNELS ${KPATH}/v2.6.24/linux-headers-2.6.24-020624-generic_2.6.24-020624_${TARGET}.deb"
 KERNELS="$KERNELS ${KPATH}/v2.6.24/linux-image-2.6.24-020624-generic_2.6.24-020624_${TARGET}.deb"
@@ -109,22 +126,6 @@ KERNELS="$KERNELS ${KPATH}/v3.4.4-quantal/linux-image-3.4.4-030404-generic_3.4.4
 
 function get_ubuntu_kernels() {
 
-	ARCH=$(uname -m)
-	TARGET=""
-
-	case $ARCH in
-	"x86_64")
-		TARGET="amd64"
-		;;
-	"i686")
-		TARGET="i386"
-		;;
-	*)
-		echo -e "Unsupported architecture"
-		exit
-		;;
-	esac
-
 	mkdir -p debs
 	cd debs
 
-- 
1.7.10.4

Re: [PATCH] compat: Fix setting $TARGET

[Ozan Çağlayan]

On Mon, Jul 9, 2012 at 2:48 PM, Ozan Çağlayan <ozancag@gmail.com> wrote:
> commit 61077651424add644401b927b52681a191bbd7f1 moved the list of
> kernels above which broke the $TARGET substitutions in them.
>
> Move the TARGET detection above of everything to fix this.
>
> Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>

I think you missed this as you've pushed the other 2 patches :)

Re: [PATCH] compat: Fix setting $TARGET

[Ozan Çağlayan]

On Tue, Jul 10, 2012 at 1:11 PM, Ozan Çağlayan <ozancag@gmail.com> wrote:
> On Mon, Jul 9, 2012 at 2:48 PM, Ozan Çağlayan <ozancag@gmail.com> wrote:
>> commit 61077651424add644401b927b52681a191bbd7f1 moved the list of
>> kernels above which broke the $TARGET substitutions in them.
>>
>> Move the TARGET detection above of everything to fix this.
>>

Well if you apply my today's commit which dynamically generates ARCH
dependent deb names when downloading, you do not need to apply this
since wget is called after setting TARGET in get_ubuntu_kernels().




-- 
Ozan Çağlayan

Re: [PATCH] compat: Fix setting $TARGET

[Luis R. Rodriguez]

On Tue, Jul 10, 2012 at 5:16 AM, Ozan Çağlayan <ozancag@gmail.com> wrote:
> On Tue, Jul 10, 2012 at 1:11 PM, Ozan Çağlayan <ozancag@gmail.com> wrote:
>> On Mon, Jul 9, 2012 at 2:48 PM, Ozan Çağlayan <ozancag@gmail.com> wrote:
>>> commit 61077651424add644401b927b52681a191bbd7f1 moved the list of
>>> kernels above which broke the $TARGET substitutions in them.
>>>
>>> Move the TARGET detection above of everything to fix this.
>>>
>
> Well if you apply my today's commit which dynamically generates ARCH
> dependent deb names when downloading, you do not need to apply this
> since wget is called after setting TARGET in get_ubuntu_kernels().

OK I applied the other one and skipped this one, thanks!

  Luis