From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: fix invalid band deref building preq IEs
Date: Mon, 09 Jul 2012 18:59:46 +0200 [thread overview]
Message-ID: <1341853186.4455.52.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1341853048-12150-1-git-send-email-arik@wizery.com> (sfid-20120709_185733_193592_62A3448A)
On Mon, 2012-07-09 at 19:57 +0300, Arik Nemtsov wrote:
> The function building probe-request IEs does not validate the band is
> supported before dereferencing it. This can result in a panic when
> all bands are traversed, as done during sched-scan start.
>
> Warn when this happens and return an empty probe request. Also fix
> sched-scan to not waste memory on unsupported bands.
>
> Signed-off-by: Arik Nemtsov <arik@wizery.com>
> ---
> better? :)
Yeah I'll apply this :-)
I do wonder though why we even bother building probe request IEs for a
band if no channels from it are listed in the sched scan request.
johannes
next prev parent reply other threads:[~2012-07-09 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 16:57 [PATCH v2] mac80211: fix invalid band deref building preq IEs Arik Nemtsov
2012-07-09 16:59 ` Johannes Berg [this message]
2012-07-09 17:04 ` Arik Nemtsov
2012-07-09 17:09 ` Johannes Berg
2012-07-09 17:14 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341853186.4455.52.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox