From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] nl80211: Avoid checking for empty WoWLAN triggers
Date: Tue, 10 Jul 2012 13:06:05 +0200 [thread overview]
Message-ID: <1341918365.4475.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1341914875-14647-1-git-send-email-mohammed@qca.qualcomm.com>
On Tue, 2012-07-10 at 15:37 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>
> Previously we would check in nl80211 with an empty
> cfg80211_wowlan structure to check for 'iw phy phyX wowlan enable'
> with empty arguments (or) no triggers and disable WoWLAN.
No ... that's not how it works. If you enable WoWLAN without any
triggers, then that's what you get: the connection is kept alive but
there are no wakeup sources. If you don't specify the triggers at all
then it's disabled.
johannes
next prev parent reply other threads:[~2012-07-10 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:07 [RFC] nl80211: Avoid checking for empty WoWLAN triggers Mohammed Shafi Shajakhan
2012-07-10 11:06 ` Johannes Berg [this message]
2012-07-10 11:16 ` Mohammed Shafi Shajakhan
2012-07-10 11:20 ` Johannes Berg
2012-07-10 11:36 ` Mohammed Shafi Shajakhan
2012-07-11 5:33 ` Mohammed Shafi Shajakhan
2012-07-12 14:24 ` Johannes Berg
2012-07-12 15:14 ` Mohammed Shafi Shajakhan
2012-07-12 15:17 ` Johannes Berg
2012-07-12 15:33 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341918365.4475.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).