linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH] etherdevice: introduce eth_broadcast_addr
Date: Tue, 10 Jul 2012 18:18:44 +0200	[thread overview]
Message-ID: <1341937124.4475.27.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120708.235808.1602900783296556684.davem@davemloft.net>

From: Johannes Berg <johannes.berg@intel.com>

A lot of code has either the memset or an inefficient copy
from a static array that contains the all-ones broadcast
address. Introduce eth_broadcast_addr() to fill an address
with all ones, making the code clearer and allowing us to
get rid of some constant arrays.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/linux/etherdevice.h |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 3d406e0..98a27cc 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -138,6 +138,17 @@ static inline void random_ether_addr(u8 *addr)
 }
 
 /**
+ * eth_broadcast_addr - Assign broadcast address
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Assign the broadcast address to the given address array.
+ */
+static inline void eth_broadcast_addr(u8 *addr)
+{
+	memset(addr, 0xff, ETH_ALEN);
+}
+
+/**
  * eth_hw_addr_random - Generate software assigned random Ethernet and
  * set device flag
  * @dev: pointer to net_device structure
-- 
1.7.10.4




  reply	other threads:[~2012-07-10 16:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 10:16 [PATCH] etherdevice: introduce broadcast_ether_addr Johannes Berg
2012-07-03 15:13 ` Joe Perches
2012-07-03 15:16   ` Johannes Berg
2012-07-09  6:58 ` David Miller
2012-07-10 16:18   ` Johannes Berg [this message]
2012-07-11  0:09     ` [PATCH] etherdevice: introduce eth_broadcast_addr Paul Gortmaker
2012-07-11  0:41       ` David Miller
2012-07-11  1:09         ` Joe Perches
2012-07-13  5:33           ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
2012-07-13  5:33             ` [PATCH net-next 4/8] wireless: Use eth_random_addr Joe Perches
2012-07-13  5:54               ` Hin-Tak Leung
2012-07-13  7:15               ` Gertjan van Wingerde
2012-07-16 10:14             ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
2012-07-16 10:29               ` David Miller
2012-07-16 11:12                 ` Felipe Balbi
2012-07-16 11:17                   ` David Miller
2012-07-17  5:39             ` David Miller
2012-07-11  7:27       ` [PATCH] etherdevice: introduce eth_broadcast_addr Johannes Berg
2012-07-11  1:07     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341937124.4475.27.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).