From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: fix set_monitor_enabled
Date: Thu, 12 Jul 2012 18:06:49 +0200 [thread overview]
Message-ID: <1342109209.4531.35.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1342109117-28348-1-git-send-email-johannes@sipsolutions.net> (sfid-20120712_180526_680352_4ABD41DD)
On Thu, 2012-07-12 at 18:05 +0200, Johannes Berg wrote:
> if (!err && ntype != otype && netif_running(dev)) {
> - cfg80211_update_iface_num(rdev, ntype, 1);
> - cfg80211_update_iface_num(rdev, otype, -1);
> + cfg80211_update_iface_num(rdev, otype,
> + CFG80211_IFACE_DOWN);
> + cfg80211_update_iface_num(rdev, ntype,
> + CFG80211_IFACE_PRE_UP);
> + cfg80211_update_iface_num(rdev, ntype,
> + CFG80211_IFACE_UP);
Ok actually the other way around like it was previously makes more sense
to avoid spurious going into/out of monitor...
johannes
prev parent reply other threads:[~2012-07-12 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 16:05 [PATCH v2] cfg80211: fix set_monitor_enabled Johannes Berg
2012-07-12 16:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342109209.4531.35.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).