From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: mac80211: optimize ieee80211_rx_status struct layout
Date: Fri, 13 Jul 2012 10:54:44 +0200 [thread overview]
Message-ID: <1342169684.4983.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120713085227.GA16445@elgon.mountain> (sfid-20120713_105245_577228_12927670)
Yay... Thanks Dan.
> drivers/net/wireless/b43/xmit.c
> 768 if (phystat0 & B43_RX_PHYST0_OFDM)
> 769 status.rate_idx = b43_plcp_get_bitrate_idx_ofdm(plcp,
> 770 phytype == B43_PHYTYPE_A);
> 771 else
> 772 status.rate_idx = b43_plcp_get_bitrate_idx_cck(plcp);
> 773 if (unlikely(status.rate_idx == -1)) {
> 774 /* PLCP seems to be corrupted.
> 775 * Drop the frame, if we are not interested in corrupted frames. */
> 776 if (!(dev->wl->filter_flags & FIF_PLCPFAIL))
> 777 goto drop;
Looks like it should have a temporary variable, I'll post a fix.
johannes
prev parent reply other threads:[~2012-07-13 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 8:52 mac80211: optimize ieee80211_rx_status struct layout Dan Carpenter
2012-07-13 8:54 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342169684.4983.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).