From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: go out of PS before sending disassoc
Date: Tue, 17 Jul 2012 12:18:40 +0200 [thread overview]
Message-ID: <1342520320.8139.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1342103733-31835-1-git-send-email-eliad@wizery.com> (sfid-20120712_163531_211284_66B44DF3)
On Thu, 2012-07-12 at 17:35 +0300, Eliad Peller wrote:
> on disassoc, ieee80211_set_disassoc() goes out of PS
> before indicating BSS_CHANGED_ASSOC (not sure why this
> is needed, but some drivers might count on the current
> behavior).
>
> However, it does it after sending the disassoc
> frame, which results in null-data frame being sent
> (in order to go out of ps) after we were already sent
> the disassoc, which is invalid.
>
> Fix it by going out of ps before sending the disassoc.
Applied, thanks
johannes
prev parent reply other threads:[~2012-07-17 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 14:35 [PATCH] mac80211: go out of PS before sending disassoc Eliad Peller
2012-07-17 10:18 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342520320.8139.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).