Re: [RFC 20/20] mac80211: use channel contexts

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2012-07-27 at 13:46 +0200, Michal Kazior wrote:

> > @@ -80,17 +79,15 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
> >
> >          sdata->drop_unencrypted = capability & WLAN_CAPABILITY_PRIVACY ? 1 : 0;
> >
> > -       local->oper_channel = chan;
> >          channel_type = ifibss->channel_type;
> >          if (!cfg80211_can_beacon_sec_chan(local->hw.wiphy, chan, channel_type))
> >                  channel_type = NL80211_CHAN_HT20;
> > -       if (!ieee80211_set_channel_type(local, sdata, channel_type)) {
> > -               /* can only fail due to HT40+/- mismatch */
> > -               channel_type = NL80211_CHAN_HT20;
> > -               WARN_ON(!ieee80211_set_channel_type(local, sdata,
> > -                                                   NL80211_CHAN_HT20));
> > -       }
> > -       ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_CHANNEL);
> > +
> > +       ieee80211_vif_release_channel(sdata);
> > +       ieee80211_vif_use_channel(sdata, chan, channel_type,
> > +                                 ifibss->fixed_channel ?
> > +                                       IEEE80211_CHANCTX_SHARED :
> > +                                       IEEE80211_CHANCTX_EXCLUSIVE);
> 
> ieee80211_vif_use_channel() may fail. Can we just ignore it here?

No, I guess we shouldn't, though it's an exclusive channel context most
of the time, so it shouldn't fail. I'll fix this, not really sure what
to do about it though.

johannes