From: Johannes Berg <johannes@sipsolutions.net>
To: Mahesh Palivela <maheshp@posedge.com>
Cc: Srinivasan B <srinivasanb@posedge.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Fix for crash in cfg80211
Date: Tue, 07 Aug 2012 18:20:25 +0200 [thread overview]
Message-ID: <1344356425.4766.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <50211696.40607@posedge.com>
On Tue, 2012-08-07 at 18:52 +0530, Mahesh Palivela wrote:
> >> dev->ethtools_ops is assigned during
> >> NETDEV_REGISTER and the same can be cleared during NETDEV_UNREGISTER.
> >
> > This doesn't make any sense to me at all.
> >
> cleanup of ethtools_ops pointer is required upon netdev_unreg
> notification. we are assigning this pointer to cfg80211_ethtool_ops on
> netdev_reg notification. Is it not required?
>
> we have seen crash when keeping cfg80211 and mac80211 loaded and lmac
> driver unloaded. With this fix, we didn't see crash. Crash doesn't
> happen right away. Only when some operation trying to access ethtool_ops.
I don't see how anything could access ethtool_ops after the netdev is
unregistered.
johannes
prev parent reply other threads:[~2012-08-07 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 7:10 [PATCH] cfg80211: Fix for crash in cfg80211 Srinivasan B
2012-08-07 11:42 ` Johannes Berg
2012-08-07 13:22 ` Mahesh Palivela
2012-08-07 16:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344356425.4766.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maheshp@posedge.com \
--cc=srinivasanb@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).