From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] compat: handle pci suspend/resume on kernel 2.6.29
Date: Tue, 07 Aug 2012 20:32:01 +0200 [thread overview]
Message-ID: <1344364321.4766.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1344363868.4766.2.camel@jlt3.sipsolutions.net> (sfid-20120807_202435_066114_3D3D3816)
On Tue, 2012-08-07 at 20:24 +0200, Johannes Berg wrote:
> On Tue, 2012-08-07 at 20:05 +0200, Johannes Berg wrote:
> > On Tue, 2012-08-07 at 10:55 -0700, Luis R. Rodriguez wrote:
> >
> > > /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.c:4922:1:
> > > error: conflicting type qualifiers for ‘il_pm_ops’
> > > In file included from
> > > /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.c:43:0:
> > > /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.h:1854:32:
> > > note: previous declaration of ‘il_pm_ops’ was here
> > > /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.c:
> > > In function ‘il_isr’:
> > > /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.c:5415:12:
> > > warning: variable ‘inta_mask’ set but not used
> > > [-Wunused-but-set-variable]
> > > CC [M] /home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/ath/ath6kl/sdio.o
> > > make[4]: *** [/home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy/common.o]
> > > Error 1
> > > make[3]: *** [/home/mcgrof/staging/2/compat-wireless-3.5-3-snpc/drivers/net/wireless/iwlegacy]
> > > Error 2
> >
> > Gee, fun, that's because of the static ... more hackery required then I
> > guess :-(
>
> Not static, of course, the "const"
This should work, but I didn't test it:
http://p.sipsolutions.net/448a4a1fe8f98b30.txt
johannes
prev parent reply other threads:[~2012-08-07 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 20:15 [PATCH] compat: handle pci suspend/resume on kernel 2.6.29 Johannes Berg
2012-08-06 19:15 ` Luis R. Rodriguez
2012-08-07 17:55 ` Luis R. Rodriguez
2012-08-07 18:05 ` Johannes Berg
2012-08-07 18:24 ` Johannes Berg
2012-08-07 18:32 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344364321.4766.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).