From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: kvalo@qca.qualcomm.com, ath6kl-devel@qualcomm.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath6kl: protect firmware from excessive WoW pattern length
Date: Mon, 20 Aug 2012 09:13:13 +0200 [thread overview]
Message-ID: <1345446793.4504.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1345076116-5053-1-git-send-email-c_tpeder@qca.qualcomm.com> (sfid-20120816_021530_554431_E3CCD682)
On Wed, 2012-08-15 at 17:15 -0700, Thomas Pedersen wrote:
> Don't accept WoW patterns longer than supported by firmware.
>
> Reported-by: Haijun Jin <nhjin@qca.qualcomm.com>
> Signed-off-by: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index bd003fe..ffa18f3 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -1876,6 +1876,9 @@ static int ath6kl_wow_usr(struct ath6kl *ar, struct ath6kl_vif *vif,
> /* Configure the patterns that we received from the user. */
> for (i = 0; i < wow->n_patterns; i++) {
>
> + if (wow->patterns[i].pattern_len > WOW_MASK_SIZE)
> + return -EINVAL;
> +
No objection, but doesn't nl80211 already validate that (assuming you
give the right pattern_max_len, of course)?
johannes
next prev parent reply other threads:[~2012-08-20 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 0:15 [PATCH] ath6kl: protect firmware from excessive WoW pattern length Thomas Pedersen
2012-08-20 7:09 ` Kalle Valo
2012-08-20 7:13 ` Johannes Berg [this message]
2012-08-20 7:29 ` Kalle Valo
2012-08-20 18:18 ` Pedersen, Thomas
2012-08-20 19:08 ` Kalle Valo
2012-08-20 20:33 ` Pedersen, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345446793.4504.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath6kl-devel@qualcomm.com \
--cc=c_tpeder@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).