From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "Goldenshtein, Victor" <victorg@ti.com>,
linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
mcgrof@frijolero.org, zefir.kurtisi@neratec.com,
adrian.chadd@gmail.com, j@w1.fi, coelho@ti.com, assaf@ti.com,
yoni.divinsky@ti.com, igalc@ti.com, adrian@freebsd.org,
nbd@nbd.name, simon.wunderlich@s2003.tu-chemnitz.de
Subject: Re: [PATCH v3 1/7] nl80211/cfg80211: add radar detection command/event
Date: Mon, 20 Aug 2012 12:33:12 +0200 [thread overview]
Message-ID: <1345458792.4459.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120810162532.GA17559@redhat.com>
On Fri, 2012-08-10 at 18:25 +0200, Stanislaw Gruszka wrote:
> On Thu, Aug 09, 2012 at 03:08:59PM +0300, Goldenshtein, Victor wrote:
> > On Thu, Aug 9, 2012 at 2:51 PM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > > On Wed, Aug 08, 2012 at 02:53:37PM +0300, Victor Goldenshtein wrote:
> > >> + cac_type = nla_get_u32(info->attrs[NL80211_ATTR_WIPHY_CHANNEL_TYPE]);
> > >> + if (cac_type != NL80211_CHAN_HT20)
> > >> + return -EOPNOTSUPP;
> > > Since only HT20 is supported, what for we have this variable?
> > >
> >
> > Security measures and preparation for future HT40.
>
> I dislike "preparation for future" thing. We have lot of stuff like
> that in kernel, which never get implemented, and only mess up the code.
>
> How near future is that?
Well, it doesn't really matter -- if you allow specifying the channel
type then you have to validate it in some way, otherwise one could
assume it works with 40 MHz, right?
johannes
next prev parent reply other threads:[~2012-08-20 10:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 11:53 [PATCH v3 0/7] nl/cfg/mac80211: add DFS master ability Victor Goldenshtein
2012-08-08 11:53 ` [PATCH v3 1/7] nl80211/cfg80211: add radar detection command/event Victor Goldenshtein
2012-08-09 11:51 ` Stanislaw Gruszka
2012-08-09 12:08 ` Goldenshtein, Victor
2012-08-10 16:25 ` Stanislaw Gruszka
2012-08-12 7:31 ` Goldenshtein, Victor
2012-08-20 10:33 ` Johannes Berg [this message]
2012-09-10 10:53 ` Johannes Berg
2012-10-03 13:53 ` Goldenshtein, Victor
2012-10-09 18:46 ` Johannes Berg
2012-10-14 13:29 ` Victor Goldenshtein
2012-08-08 11:53 ` [PATCH v3 2/7] mac80211: " Victor Goldenshtein
2012-08-10 16:28 ` Stanislaw Gruszka
2012-08-12 7:31 ` Goldenshtein, Victor
2012-08-13 7:36 ` Stanislaw Gruszka
2012-08-20 7:21 ` Goldenshtein, Victor
2012-09-10 10:54 ` Johannes Berg
2012-09-10 11:17 ` Johannes Berg
2012-10-03 13:53 ` Goldenshtein, Victor
2012-08-08 11:53 ` [PATCH v3 3/7] nl80211/cfg80211: add ability to enable TX on op-channel Victor Goldenshtein
2012-08-08 11:53 ` [PATCH v3 4/7] mac80211: " Victor Goldenshtein
2012-09-10 11:20 ` Johannes Berg
2012-10-03 13:53 ` Goldenshtein, Victor
2012-08-08 11:53 ` [PATCH v3 5/7] nl80211/cfg80211: add ap channel switch command Victor Goldenshtein
2012-09-10 11:23 ` Johannes Berg
2012-10-03 13:53 ` Goldenshtein, Victor
2012-10-09 18:44 ` Johannes Berg
2012-10-14 13:29 ` Victor Goldenshtein
2012-08-08 11:53 ` [PATCH v3 6/7] mac80211: add ap channel switch command/event Victor Goldenshtein
2012-08-10 16:36 ` Stanislaw Gruszka
2012-08-12 7:31 ` Goldenshtein, Victor
2012-08-13 7:34 ` Stanislaw Gruszka
2012-08-20 10:32 ` Johannes Berg
2012-09-10 11:25 ` Johannes Berg
2012-10-03 13:54 ` Goldenshtein, Victor
2012-10-04 15:42 ` Goldenshtein, Victor
2012-08-08 11:53 ` [PATCH v3 7/7] mac80211: add DFS support to monitor interface Victor Goldenshtein
2012-09-10 11:26 ` Johannes Berg
2012-10-03 13:54 ` Goldenshtein, Victor
2012-10-09 18:42 ` Johannes Berg
2012-10-14 13:29 ` Victor Goldenshtein
2012-09-07 15:47 ` [PATCH v3 0/7] nl/cfg/mac80211: add DFS master ability Simon Wunderlich
2012-09-07 16:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345458792.4459.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian.chadd@gmail.com \
--cc=adrian@freebsd.org \
--cc=assaf@ti.com \
--cc=coelho@ti.com \
--cc=igalc@ti.com \
--cc=j@w1.fi \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=victorg@ti.com \
--cc=yoni.divinsky@ti.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).