* [PATCH] ath5k: set hw mfp capable flag for secured mesh
@ 2012-08-24 3:29 Chun-Yeow Yeoh
2012-08-24 6:55 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Chun-Yeow Yeoh @ 2012-08-24 3:29 UTC (permalink / raw)
To: linux-wireless; +Cc: jirislaby, mickflemm, mcgrof, ath5k-devel, Chun-Yeow Yeoh
The IEEE80211_HW_MFP_CAPABLE is required to ensure the
successful key installation of CIPHER_AES_CMAC (currently
done in software) for secured mesh.
Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
drivers/net/wireless/ath/ath5k/base.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index a0a202d..4605fe1 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2446,7 +2446,8 @@ ath5k_init_ah(struct ath5k_hw *ah, const struct ath_bus_ops *bus_ops)
hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
IEEE80211_HW_SIGNAL_DBM |
- IEEE80211_HW_REPORTS_TX_ACK_STATUS;
+ IEEE80211_HW_REPORTS_TX_ACK_STATUS |
+ IEEE80211_HW_MFP_CAPABLE;
hw->wiphy->interface_modes =
BIT(NL80211_IFTYPE_AP) |
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath5k: set hw mfp capable flag for secured mesh
2012-08-24 3:29 [PATCH] ath5k: set hw mfp capable flag for secured mesh Chun-Yeow Yeoh
@ 2012-08-24 6:55 ` Johannes Berg
2012-08-24 10:07 ` Yeoh Chun-Yeow
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2012-08-24 6:55 UTC (permalink / raw)
To: Chun-Yeow Yeoh; +Cc: linux-wireless, jirislaby, mickflemm, mcgrof, ath5k-devel
On Fri, 2012-08-24 at 11:29 +0800, Chun-Yeow Yeoh wrote:
> The IEEE80211_HW_MFP_CAPABLE is required to ensure the
> successful key installation of CIPHER_AES_CMAC (currently
> done in software) for secured mesh.
You shouldn't blindly set the flag though because it "is required". You
really need to test that management frames aren't decrypted by the
hardware erroneously.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath5k: set hw mfp capable flag for secured mesh
2012-08-24 6:55 ` Johannes Berg
@ 2012-08-24 10:07 ` Yeoh Chun-Yeow
0 siblings, 0 replies; 3+ messages in thread
From: Yeoh Chun-Yeow @ 2012-08-24 10:07 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, jirislaby, mickflemm, mcgrof, ath5k-devel
> You shouldn't blindly set the flag though because it "is required". You
> really need to test that management frames aren't decrypted by the
> hardware erroneously.
Noted. Will take a look on alternative solution for this.
--
Chun-Yeow
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-24 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-24 3:29 [PATCH] ath5k: set hw mfp capable flag for secured mesh Chun-Yeow Yeoh
2012-08-24 6:55 ` Johannes Berg
2012-08-24 10:07 ` Yeoh Chun-Yeow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).