From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Antonio Quartulli <ordex@autistici.org>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>,
ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 2/2] ath9k_htc: advertise allowed VIFs combination
Date: Mon, 27 Aug 2012 07:38:01 +0200 [thread overview]
Message-ID: <1346045881.3746.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAGRGNgUoNnuh_23qzULJyJcvMUgNpUxFnZjaAcGj26_jrTHdeA@mail.gmail.com> (sfid-20120827_014933_243805_D149F43D)
On Mon, 2012-08-27 at 09:48 +1000, Julian Calaby wrote:
> Antonio,
>
> On Mon, Aug 27, 2012 at 6:55 AM, Antonio Quartulli <ordex@autistici.org> wrote:
> > This driver now advertises its allowed VIFs combinations to the mac80211
> > sublayer.
> >
> > Other than that, practical tests shown that ath9k_htc devices allow an IBSS VIF
> > to coexist with VIF set up on other modes. This patch removes the check which
> > block the creation of any other VIF whenever an IBSS one is already present.
>
> These two patches should really be applied in the opposite order:
>
> You should add the interface combination data (this patch) then remove
> the old checking code.
>
> This way there's not a window (admittedly only one patch) where the
> interface combinations aren't enforced.
FWIW, it's the other way around, in that window no combinations would be
permitted at all...
johannes
next prev parent reply other threads:[~2012-08-27 5:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 20:55 [PATCHv2 1/2] ath9k_htc: remove driver specific checks for interfaces combinations Antonio Quartulli
2012-08-26 20:55 ` [PATCHv2 2/2] ath9k_htc: advertise allowed VIFs combination Antonio Quartulli
2012-08-26 23:48 ` Julian Calaby
2012-08-27 5:38 ` Johannes Berg [this message]
2012-08-27 5:41 ` Julian Calaby
2012-08-27 6:42 ` Antonio Quartulli
2012-08-27 6:45 ` Julian Calaby
2012-08-27 7:16 ` ath9k_htc: number of VIFs limitation Daniel Doron
2012-09-26 20:11 ` Adrian Chadd
2012-08-27 5:17 ` [PATCHv2 1/2] ath9k_htc: remove driver specific checks for interfaces combinations Mohammed Shafi
2012-08-27 6:54 ` Antonio Quartulli
2012-08-27 9:15 ` Mohammed Shafi
2012-08-27 9:42 ` Antonio Quartulli
2012-09-03 14:01 ` Mohammed Shafi
2012-09-04 7:07 ` Antonio Quartulli
2012-09-04 7:47 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346045881.3746.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@lists.ath9k.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).