From: Johannes Berg <johannes@sipsolutions.net>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL
Date: Tue, 04 Sep 2012 11:30:37 +0200 [thread overview]
Message-ID: <1346751037.3737.24.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <5045C79A.6050308@qca.qualcomm.com>
On Tue, 2012-09-04 at 14:49 +0530, Vasanthakumar Thiagarajan wrote:
> >> + if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP&&
> >> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
> >> + return -EOPNOTSUPP;
> >
> > This also needs to check that the interface is operating already in AP
> > mode.
>
> Sorry, not sure I get this. Is it not that configuring acl list
> when dev->ieee80211_ptr->iftype == NL80211_IFTYPE_AP is already
> taken care.
Well you say that on start_ap the list must be cleared. Therefore,
updating the list only makes sense after start_ap, not before, so you
should refuse it being set before start_ap.
johannes
prev parent reply other threads:[~2012-09-04 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 12:23 [RFC 1/2] cfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-09-03 12:23 ` [RFC 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL Vasanthakumar Thiagarajan
2012-09-04 6:29 ` Kalle Valo
2012-09-04 8:45 ` Vasanthakumar Thiagarajan
2012-09-04 8:38 ` Johannes Berg
2012-09-04 9:19 ` Vasanthakumar Thiagarajan
2012-09-04 9:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346751037.3737.24.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).