linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, jirislaby@gmail.com,
	mickflemm@gmail.com, mcgrof@qca.qualcomm.com,
	ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH] ath5k: add support of HW encryption in management frames
Date: Tue, 04 Sep 2012 11:31:42 +0200	[thread overview]
Message-ID: <1346751102.3737.25.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAEFj9861rR+yEcJbtZjnwqO5LQXEbjRgxaM+StTBkJKxXPximw@mail.gmail.com> (sfid-20120904_112842_613203_3FC30AEF)

On Tue, 2012-09-04 at 17:28 +0800, Yeoh Chun-Yeow wrote:
> Hi, Johannes
> 
> > _How_ did you test this? Did you test that management frames are
> > properly encrypted using AES CCM, and not mangled when decrypted?
> 
> I have setup the two mesh nodes using the secured mesh with the
> following key installation:
> 
> /* key to encrypt/decrypt unicast data AND mgmt traffic to/from this peer */
> install_key(&nlcfg, peer, CIPHER_CCMP, NL80211_KEYTYPE_PAIRWISE, 0, mtk);
> 
> I confirm that the hardware key for CCMP is set and
> IEEE80211_KEY_FLAG_SW_MGMT is not enabled in mac80211-ops.c. Both
> nodes are able to ping each others. Is this enough?

I don't know? Did this encrypt any management frames with AES-CCM and
rely on them being exchanged properly?

johannes


  reply	other threads:[~2012-09-04  9:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  9:34 [PATCH] ath5k: add support of HW encryption in management frames Chun-Yeow Yeoh
2012-08-31  6:58 ` Adrian Chadd
2012-08-31 15:24   ` Yeoh Chun-Yeow
2012-09-03 19:24     ` Adrian Chadd
2012-09-04  1:03       ` Yeoh Chun-Yeow
2012-09-04  8:11 ` Johannes Berg
2012-09-04  9:28   ` Yeoh Chun-Yeow
2012-09-04  9:31     ` Johannes Berg [this message]
2012-09-04 10:22     ` Jouni Malinen
2012-09-04 11:21       ` Yeoh Chun-Yeow
2012-09-04 11:25         ` Yeoh Chun-Yeow
2012-09-04 11:35           ` Johannes Berg
2012-09-04 16:41             ` Yeoh Chun-Yeow
2012-09-04 16:54               ` Johannes Berg
2012-09-05  6:52                 ` Yeoh Chun-Yeow
2012-09-04 16:55               ` Christian Lamparter
2012-09-04 16:57                 ` Johannes Berg
2012-09-05  7:16               ` Jouni Malinen
2012-09-05  7:31                 ` Yeoh Chun-Yeow
2012-09-05  8:03                   ` Jouni Malinen
2012-09-07  3:51                     ` Yeoh Chun-Yeow
2012-09-09  1:47                       ` Adrian Chadd
2012-09-10 13:13                         ` Kalle Valo
2012-09-10 15:11                           ` Yeoh Chun-Yeow
2012-09-11  6:46                             ` Nick Kossifidis
2012-09-11  9:42                               ` Yeoh Chun-Yeow
2012-09-11 15:05                                 ` Nick Kossifidis
2012-09-11 15:51                                   ` Yeoh Chun-Yeow
2012-09-11 16:06                                     ` Nick Kossifidis
2012-09-11 16:07                                       ` Nick Kossifidis
2012-09-11 16:20                                         ` Yeoh Chun-Yeow
2012-09-11 16:30                                           ` Adrian Chadd
2012-09-11 16:36                                           ` Nick Kossifidis
2012-09-11 16:39                                             ` Johannes Berg
2012-09-11 17:31                                             ` Christian Lamparter
2012-09-11 17:48                                               ` Nick Kossifidis
2012-09-05  7:11             ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346751102.3737.25.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@qca.qualcomm.com \
    --cc=mickflemm@gmail.com \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).