From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:41318 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757065Ab2IDOPN (ORCPT ); Tue, 4 Sep 2012 10:15:13 -0400 Message-ID: <1346768149.3737.29.camel@jlt4.sipsolutions.net> (sfid-20120904_161517_030820_FAA4EA37) Subject: Re: [PATCH v2] p54: connect to 11w protected networks From: Johannes Berg To: Christian Lamparter Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com Date: Tue, 04 Sep 2012 16:15:49 +0200 In-Reply-To: (sfid-20120904_155321_955424_2D6B3F4B) References: <1346622538.10113.3.camel@jlt4.sipsolutions.net> (sfid-20120904_155321_955424_2D6B3F4B) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2012-09-04 at 15:19 +0200, Christian Lamparter wrote: > As you feared: the firmware is corrupting incoming management > frames. However, it does so only when a rxkey was configured. > So as a possible trade-off, MFP will only be supported by p54, > when the firmware crypto offloading is relieved of his duties > (disabled). > > Note: Strictly speaking, it would be enough to no longer upload > any rx key which could affect management frames, as the firmware > does not decrypt any frames unless there is a fitting key candidate. Right, however, that would kinda defeat the point. Unless ... maybe we can tell the driver if 11w is going to be used at all? If we did that, we could make it work in the set_key callback. For now your patch looks good though. johannes