linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH v2] p54: connect to 11w protected networks
Date: Tue, 04 Sep 2012 09:33:04 -0500	[thread overview]
Message-ID: <1346769184.26638.7.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1346768149.3737.29.camel@jlt4.sipsolutions.net>

On Tue, 2012-09-04 at 16:15 +0200, Johannes Berg wrote:
> On Tue, 2012-09-04 at 15:19 +0200, Christian Lamparter wrote:
> 
> > As you feared: the firmware is corrupting incoming management
> > frames. However, it does so only when a rxkey was configured.
> > So as a possible trade-off, MFP will only be supported by p54,
> > when the firmware crypto offloading is relieved of his duties
> > (disabled). 
> > 
> > Note: Strictly speaking, it would be enough to no longer upload
> > any rx key which could affect management frames, as the firmware
> > does not decrypt any frames unless there is a fitting key candidate.
> 
> Right, however, that would kinda defeat the point. Unless ... maybe we
> can tell the driver if 11w is going to be used at all? If we did that,
> we could make it work in the set_key callback.
> 
> For now your patch looks good though.

We can't get this to happen without a module option?  Is there a way to
turn the crypto offloading off when we know we're connecting to a W
protected AP?

Dan


  reply	other threads:[~2012-09-04 14:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02 13:22 [PATCH] p54: connect to 11w protected networks Christian Lamparter
2012-09-02 21:48 ` Johannes Berg
2012-09-04 13:19   ` [PATCH v2] " Christian Lamparter
2012-09-04 14:15     ` Johannes Berg
2012-09-04 14:33       ` Dan Williams [this message]
2012-09-04 14:37         ` Johannes Berg
2012-09-04 14:54           ` Johannes Berg
2012-09-07 12:17             ` Johannes Berg
2012-09-07 15:47               ` Christian Lamparter
2012-09-07 15:55                 ` Johannes Berg
2012-09-07 16:10                   ` Christian Lamparter
2012-09-07 16:15                     ` Johannes Berg
2012-09-07 16:26                       ` Christian Lamparter
     [not found]   ` <201209071825.13588.chunkeey@googlemail.com>
     [not found]     ` <1347035277.4256.33.camel@jlt4.sipsolutions.net>
2012-09-07 17:01       ` Christian Lamparter
2012-09-07 17:09         ` Johannes Berg
2012-09-07 17:28           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346769184.26638.7.camel@dcbw.foobar.com \
    --to=dcbw@redhat.com \
    --cc=chunkeey@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).