From: Johannes Berg <johannes@sipsolutions.net>
To: Antonio Quartulli <ordex@autistici.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] cfg/nl/mac80211: use per-band basic rates bitmap in IBSS
Date: Tue, 04 Sep 2012 21:38:44 +0200 [thread overview]
Message-ID: <1346787524.3737.43.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1346784741-7003-1-git-send-email-ordex@autistici.org>
On Tue, 2012-09-04 at 20:52 +0200, Antonio Quartulli wrote:
> Each band maps the bitmap of rates to different real bitrates, therefore using
> the same bitmask for every band (as it is now) is not correct.
> Each band must have its own bitmask where the bits of the rates specified by the
> user on IBSS join have to be set
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> include/net/cfg80211.h | 4 ++--
> net/mac80211/ibss.c | 6 ++++--
> net/mac80211/ieee80211_i.h | 2 +-
> net/wireless/nl80211.c | 12 +++++++-----
I'm not sure I see the need to change nl80211, and the change seems
wrong anyway.
As far as I understand it, the basic rates that are passed into the
kernel are intended to be used when the kernel creates a new IBSS. This
always happens on the channel that is also passed in, so it's always
bound to a given channel (band).
Now mac80211 internally seems to mess this up a bit, but that doesn't
affect nl80211/cfg80211?
johannes
next prev parent reply other threads:[~2012-09-04 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 18:52 [RFC] cfg/nl/mac80211: use per-band basic rates bitmap in IBSS Antonio Quartulli
2012-09-04 19:38 ` Johannes Berg [this message]
2012-09-04 19:45 ` Antonio Quartulli
2012-09-04 19:47 ` Johannes Berg
2012-09-05 6:34 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346787524.3737.43.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).