From: Johannes Berg <johannes@sipsolutions.net>
To: Antonio Quartulli <ordex@autistici.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: reply to AUTH frame with a DEAUTH if sta allocation fails
Date: Wed, 05 Sep 2012 15:58:23 +0200 [thread overview]
Message-ID: <1346853503.4364.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1345995273-27358-2-git-send-email-ordex@autistici.org>
On Sun, 2012-08-26 at 17:34 +0200, Antonio Quartulli wrote:
> Whenever a host gets an AUTH frame it first allocates a new station and then
> replies with another AUTH frame. However, if sta allocations fails the host
> should send a DEAUTH frame instead to tell the other end that something went
> wrong
Well, ok, but...
> /*
> + * if we have any problem in allocating the new station, we reply with a
> + * DEAUTH frame to tell the other end that we had a problem
> + */
> + if (!sta) {
> + ieee80211_send_deauth_disassoc(sdata, sdata->u.ibss.bssid,
> + IEEE80211_STYPE_DEAUTH,
> + WLAN_REASON_UNSPECIFIED, true,
> + deauth_frame_buf);
You can't call the function in IBSS mode, it accesses sdata->u.mgd. You
should probably fix that in the first patch and make it conditional on
the sdata->vif.type actually being station mode.
johannes
next prev parent reply other threads:[~2012-09-05 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 15:34 [PATCH 1/2] mac80211: export ieee80211_send_deauth_disassoc for usage outside of mlme.c Antonio Quartulli
2012-08-26 15:34 ` [PATCH 2/2] mac80211: reply to AUTH frame with a DEAUTH if sta allocation fails Antonio Quartulli
2012-09-05 13:58 ` Johannes Berg [this message]
2012-09-05 14:37 ` Antonio Quartulli
-- strict thread matches above, loose matches on Subject: below --
2012-09-07 11:28 [PATCHv3 1/2] mac80211: export ieee80211_send_deauth_disassoc for usage outside of mlme.c Antonio Quartulli
2012-09-07 11:28 ` [PATCH 2/2] mac80211: reply to AUTH frame with a DEAUTH if sta allocation fails Antonio Quartulli
2012-09-07 11:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346853503.4364.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).