linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: regression: tethering fails in 3.5 with iwlwifi
Date: Thu, 20 Sep 2012 16:39:45 +0300	[thread overview]
Message-ID: <1348148385.2388.21.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1348147322.31352.69.camel@edumazet-glaptop>

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Thu, 2012-09-20 at 15:22 +0200, Eric Dumazet wrote:
> On Thu, 2012-09-20 at 16:22 +0300, Artem Bityutskiy wrote:
> 
> > 
> > OK, I've tried almost this (see below) and it solves my issue:
> > 
> > diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> > index 965e6ec..7f079d0 100644
> > --- a/net/mac80211/rx.c
> > +++ b/net/mac80211/rx.c
> > @@ -1798,9 +1798,13 @@ ieee80211_deliver_skb(struct ieee80211_rx_data *rx)
> >  
> >                 if (skb) {
> >                         /* deliver to local stack */
> > -                       skb->protocol = eth_type_trans(skb, dev);
> > -                       memset(skb->cb, 0, sizeof(skb->cb));
> > -                       netif_receive_skb(skb);
> > +                       if (pskb_may_pull(skb, 40)) {
> > +                               skb->protocol = eth_type_trans(skb, dev);
> > +                               memset(skb->cb, 0, sizeof(skb->cb));
> > +                               netif_receive_skb(skb);
> > +                       } else {
> > +                               kfree_skb(skb);
> > +                       }
> >                 }
> >         }
> > 
> 
> OK but you cant do that, or small frames will be dropped.
> 
> Anyway its a hack, we should find the buggy layer.
> 
> You could use dropwatch (drop_monitor) to check where frame is dropped.
> 
> modprobe drop_monitor
> dropwatch -l kas

I do not have dropwatch in Tizen, I need to find the sources and compile
the user-space part. Any hint where to download it?

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-09-20 13:34 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1347361823.26457.3.camel@sauron.fi.intel.com>
     [not found] ` <1DC40B07CD6EC041A66726C271A73AE6195AE9C8@IRSMSX102.ger.corp.intel.com>
2012-09-14 14:02   ` regression: tethering fails in 3.5 with iwlwifi Artem Bityutskiy
2012-09-14 16:39     ` Artem Bityutskiy
2012-09-17 14:41       ` Artem Bityutskiy
2012-09-17 15:15         ` Eric Dumazet
2012-09-17 15:17           ` Johannes Berg
2012-09-18  7:09         ` Johannes Berg
2012-09-18  8:40           ` Artem Bityutskiy
2012-09-18  8:44             ` Johannes Berg
2012-09-18 11:45               ` Johannes Berg
2012-09-18 13:20                 ` Artem Bityutskiy
2012-09-20 12:06         ` Artem Bityutskiy
2012-09-20 12:35           ` Johannes Berg
2012-09-20 12:40             ` Eric Dumazet
2012-09-20 12:45               ` Eric Dumazet
2012-09-20 12:46                 ` Eric Dumazet
2012-09-20 12:50                   ` Johannes Berg
2012-09-20 12:47                 ` Johannes Berg
2012-09-20 12:48                   ` Eric Dumazet
2012-09-20 12:50                     ` Johannes Berg
2012-09-20 12:51                       ` Eric Dumazet
2012-09-20 12:54                         ` Johannes Berg
2012-09-20 12:51                   ` Johannes Berg
2012-09-20 12:58                 ` Artem Bityutskiy
2012-09-20 13:04                   ` Eric Dumazet
2012-09-20 13:15                     ` Eric Dumazet
2012-09-20 13:22                     ` Artem Bityutskiy
2012-09-20 13:22                       ` Eric Dumazet
2012-09-20 13:39                         ` Artem Bityutskiy [this message]
2012-09-20 13:41                           ` Eric Dumazet
2012-09-20 14:25                       ` Eric Dumazet
2012-09-20 14:37                         ` Artem Bityutskiy
2012-09-20 14:56                           ` Eric Dumazet
2012-09-20 15:05                             ` Johannes Berg
2012-09-20 15:18                               ` Eric Dumazet
2012-09-20 15:22                                 ` Johannes Berg
2012-09-20 15:27                                   ` Eric Dumazet
2012-09-20 15:31                                     ` Eric Dumazet
2012-09-20 15:32                                       ` Eric Dumazet
2012-09-20 15:19                               ` Eric Dumazet
2012-09-20 15:26                                 ` Johannes Berg
2012-09-20 15:09                             ` Artem Bityutskiy
2012-09-21 17:24                         ` David Miller
2012-09-20 12:47               ` Johannes Berg
2013-03-21 19:34         ` Johannes Berg
2013-03-21 21:24           ` David Miller
2013-03-22  7:01           ` Artem Bityutskiy
2013-03-23 15:45           ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348148385.2388.21.camel@sauron.fi.intel.com \
    --to=artem.bityutskiy@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).