From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith Manoharan <c_manoha@qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: Notify new IBSS network creation
Date: Wed, 26 Sep 2012 10:19:09 +0200 [thread overview]
Message-ID: <1348647549.10548.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20578.47013.636428.710724@gargle.gargle.HOWL>
On Wed, 2012-09-26 at 13:37 +0530, Sujith Manoharan wrote:
> Johannes Berg wrote:
> > That looks a bit different from what I thought though? Not really sure I
> > understand that though :-)
>
> The basic issue was that we were not initializing the timers based on
> the sync'd TSF.
>
> > What I'm thinking is that if you always just start beaconing, wouldn't
> > you just reset the beacon whenever you notice a higher TSF show up in
> > the network?
> >
> > Actually I think we call reset_tsf() or something like that? But all of
> > that has always seemed very quirky to me.
>
> Currently, I don't think we reset the beacon/timers for IBSS mode.
>
> For station mode, all of this is handled in ath9k using the
> PS_WAIT_FOR_BEACON/PS_BEACON_SYNC flags. For IBSS creator mode, there is
> no problem because mac80211 calls reset_tsf() in __ieee80211_sta_join_ibss().
> For joiner mode, drivers like ath9k need to do a beacon-sync (like station),
> before starting to pollute the environment with beacons, but there is no way to know
> if an existing IBSS network is being joined.
Right, makes sense. I have no objections to this patch, just wanted to
understand the issue better.
johannes
next prev parent reply other threads:[~2012-09-26 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 3:42 [RFC] mac80211: Notify new IBSS network creation Sujith Manoharan
2012-09-26 7:14 ` Johannes Berg
2012-09-26 7:29 ` Sujith Manoharan
2012-09-26 7:37 ` Johannes Berg
2012-09-26 8:07 ` Sujith Manoharan
2012-09-26 8:19 ` Johannes Berg [this message]
2012-09-26 8:24 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348647549.10548.8.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=c_manoha@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox