Re: [PATCH v2] mac80211: VHT peer STA caps

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2012-09-26 at 08:45 +0530, Mahesh Palivela wrote:
> On 09/25/2012 07:39 PM, Johannes Berg wrote:
> >
> > Well imagine you have a driver for some hardware that can do
> > beamforming, and the same driver can also work with hardware that
> > doesn't. If we restrict remote caps, like we do for HT, the driver
> > doesn't have to worry about this but can just do whatever the remote
> > caps say is possible. If we don't restrict it, the driver has to also
> > check its own caps.
> 
> you mean to say some drivers which dont provide its own VHT caps, will 
> use remote STA VHT caps as its own?
> If so I feel not correct posing remote STA caps as local caps.

No, no. If you look at HT, then you'll see that if the driver has HT but
isn't capable of doing everything the peer STA can do, then mac80211
restricts tells the driver only about the peer capabilities that the
device can do as well.

I agree that this isn't really necessary and can be rather complex in
VHT, but I think you need to document the difference very clearly in the
documentation for the ieee80211_sta VHT caps.

johannes