Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sam Leffler <sleffler@chromium.org>
Cc: "John W . Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, eliad <eliad@wizery.com>,
	coelho <coelho@ti.com>
Subject: Re: [PATCH 0/3] add scan flags support
Date: Fri, 28 Sep 2012 12:57:20 +0200	[thread overview]
Message-ID: <1348829840.13298.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+yqC4bo9Xcy9HMeJYAFHqEYBCUErF+Y4ivfe9s+xQ+endCU-Q@mail.gmail.com> (sfid-20120927_183915_117447_7AEFBA98)

On Thu, 2012-09-27 at 09:39 -0700, Sam Leffler wrote:

> > Maybe it'd be worthwhile to go for a more generic approach, marking
> > scans as "low priority" or "high priority" or similar, and then
> > implementing such behaviour based on such settings? Our device for
> > example has a notion of "background scan" vs. "forced scan", which
> > behave differently in the firmware, and it would be useful to be able to
> > use these different behaviours. However, I can't say that "TX abort"
> > would be a guaranteed scan behaviour for a "background scan".
> 
> Having a priority mechanism or similar would be fine. I usually
> hesitate doing the generic thing because the actual semantics can very
> so significantly from driver to driver that applications may end up
> having to build in knowledge of which driver is being used to get what
> they way want. But in fact what you suggest is how txabort is used--we
> mark wpa_supplicant bgscan's w/ txabort while fgscan's are not marked
> in this way.

Yes, I agree it's a slippery slope, however with all the different
mechanisms that can be built in drivers/firmware/... I'm not really sure
how else to treat them?

In theory we could say that we have
 * TX abort
 * Intel BG scan (otherwise opaque, in firmware)
 * TI BG scan (otherwise opaque, in firmware)
 * ...

as separate flags/settings/..., but ultimately it seems that all that
would happen is that everybody would patch the supplicant to use their
mechanism for background scanning if available. Then, in theory, the
supplicant would know which one it's using, but since it doesn't really
know the semantics it doesn't really make a difference?

Maybe we should agree on a few basic rules for the "generic" BG scan,
but I'm not sure what sensible rules would be. They can't be rules on
reliability, as then "tx-abort" wouldn't be a valid implementation
(unless you retried, but that could literally run forever), and I'm not
sure what other kind of rule would make sense. Either way, the
supplicant is going to have to assume that a finished "BG scan" has a
smaller result set than a "regular" scan ...

There might be value in having more information about the actual "abort
due to TX" (whether it happened or not), but again that would be tied to
the specific implementation, and I'm not sure how to formulate any such
thing more generically. Right now, I don't even know how our or TI's
implementation behaves differently for the different types of scan.

johannes


  reply	other threads:[~2012-09-28 10:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 22:49 [PATCH 0/3] add scan flags support Sam Leffler
2012-09-26 19:44 ` Bing Zhao
2012-09-27  9:13 ` Johannes Berg
2012-09-27  9:31   ` Eliad Peller
2012-09-27  9:43     ` Arik Nemtsov
2012-09-27 16:43     ` Sam Leffler
2012-09-27 16:39   ` Sam Leffler
2012-09-28 10:57     ` Johannes Berg [this message]
2012-09-28 20:27       ` Sam Leffler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348829840.13298.17.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=coelho@ti.com \
    --cc=eliad@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sleffler@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox