From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Sam Leffler <sleffler@chromium.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Avinash Patil <patila@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Stone Piao <piaoyun@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH v2 4/5] mac80211: add support for tx to abort low priority scan requests
Date: Fri, 28 Sep 2012 13:06:41 +0200 [thread overview]
Message-ID: <1348830401.13298.27.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1348772354-15936-5-git-send-email-bzhao@marvell.com>
On Thu, 2012-09-27 at 11:59 -0700, Bing Zhao wrote:
> + if (associated && !tx_empty) {
> + if (unlikely(local->scan_req->flags &
> + CFG80211_SCAN_FLAG_LOW_PRIORITY))
I don't really see value in the "unlikely()" here, that just clutters
the code and probably has very little effect on the runtime behaviour,
this is very infrequently executed.
> + case SCAN_ABORT:
> + aborted = true;
> + goto out_complete;
Maybe we should have different flags though ... I mean, this is the
first implementation that I hear of that interprets a background scan as
"ok to abort at any time"? It seems very unlikely that other
implementations would do that. I *think* (like I said before, I don't
really know) that ours (Intel's) will just shorten the dwell time, or
similar instead.
johannes
next prev parent reply other threads:[~2012-09-28 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 18:59 [PATCH v2 0/5] add scan flags support Bing Zhao
2012-09-27 18:59 ` [PATCH v2 1/5] {nl,cfg}80211: add a flags word to scan requests Bing Zhao
2012-09-28 11:01 ` Johannes Berg
2012-09-28 20:36 ` Sam Leffler
2012-10-01 11:14 ` Johannes Berg
2012-09-27 18:59 ` [PATCH v2 2/5] cfg80211: add scan flag to indicate its priority Bing Zhao
2012-09-27 18:59 ` [PATCH v2 3/5] cfg80211: add support for flushing old scan results Bing Zhao
2012-09-28 11:04 ` Johannes Berg
2012-09-28 19:47 ` Bing Zhao
2012-10-01 11:06 ` Johannes Berg
2012-09-27 18:59 ` [PATCH v2 4/5] mac80211: add support for tx to abort low priority scan requests Bing Zhao
2012-09-28 11:06 ` Johannes Berg [this message]
2012-09-28 20:38 ` Sam Leffler
2012-10-01 11:15 ` Johannes Berg
2012-09-27 18:59 ` [PATCH v2 5/5] mwifiex: use LOW_PRIORITY flag provided in scan request Bing Zhao
2012-09-28 11:07 ` Johannes Berg
2012-09-28 19:50 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348830401.13298.27.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=patila@marvell.com \
--cc=piaoyun@marvell.com \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).