Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless <linux-wireless@vger.kernel.org>
Cc: Paul Stewart <pstew@chromium.org>
Subject: Re: [RFC] mac80211: connect with HT20 if HT40 is not permitted
Date: Mon, 01 Oct 2012 16:17:19 +0200	[thread overview]
Message-ID: <1349101039.10330.41.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1349100121.10330.36.camel@jlt4.sipsolutions.net> (sfid-20121001_160132_854322_0F7EDEE5)

On Mon, 2012-10-01 at 16:02 +0200, Johannes Berg wrote:

> Fix this, while avoiding the "Korean AP" issue by
> disabling HT40 and advertising HT20 to the AP
> when connecting.

> +		case IEEE80211_HT_PARAM_CHA_SEC_ABOVE:
> +			if (cbss->channel->flags & IEEE80211_CHAN_NO_HT40PLUS)

What we *could* do instead is use "channel->orig_flags" here instead to
fix the iwlwifi issue, and allow HT40 RX for when the driver/device has
no limitations (and the HT40 restriction would be regulatory only), but
I'm not sure I see much value in that? That might enable HT40 RX (not
TX) for some devices on those Korean HT40 APs though, but it'd also be
somewhat tricky in the code and more or less relying on cfg80211
internals ... I'd prefer not to introduce these kinds of subtle
differences between devices but if somebody has strong objections to the
patch as is I'd be willing to change it.

johannes


  reply	other threads:[~2012-10-01 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01 14:02 [RFC] mac80211: connect with HT20 if HT40 is not permitted Johannes Berg
2012-10-01 14:17 ` Johannes Berg [this message]
2012-10-16 18:19 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349101039.10330.41.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pstew@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox