Re: [PATCH 3.7 1/2] cfg80211: fix antenna gain handling

[Johannes Berg <johannes@sipsolutions.net>]

On Sat, 2012-10-06 at 14:26 +0200, Felix Fietkau wrote:

> > I was not understanding the usage scenario here. Your patch will ignore 
> > any driver initialized max antenna gain, which does not sound right to 
> > me. What if chan->orig_mag is a sensible (non-zero) value, which is 
> > lower than the value in regulatory power rule? Just seems that the patch 
> > changes more than the commit message it saying.
> I did take another close look at the code and it seems you're right. I
> will change the code so that it initializes chan->orig_mag to INT_MAX in
> wiphy_register, and I will make the patch description a bit more verbose
> as well.
> That way the chan->max_antenna_gain value supplied by the driver gets
> ignored, which is a good thing, considering that only one driver
> actually uses max_antenna_gain, and no driver initializes it to
> something useful.

I know we need the "limit to driver value" behaviour for TX power for
sure (otherwise the firmware would assert if it goes over)

johannes