Re: [RFC v2] cfg80211: VHT regulatory

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2012-09-28 at 23:04 +0530, Mahesh Palivela wrote:

> >> I prefer MHz for center freqs, but offset for the primary channel, and
> >> this is exactly like table 22-22 in the 802.11ac draft, so only the "u16
> >> primary_channel_freq" becomes "u8 primary_channel_offset", not all of
> >> them change, no?
> >
> > Ohh, wait, it's called frequency in table 22-22 but actually says the
> > valid range is 1-200 ... wtf? Ok you're right, then it uses the equation
> > 22-99, but ... hmm that's a bit stupid since it needs the (non-constant)
> > "Channel starting frequency".
> >
> > Ok so maybe that wasn't such a good idea. How about we just change
> > prim_chan_freq to prim_chan_offset and leave the other two unchanged?
> 
> we need "channel starting frequency" anyways for calculating center 
> freq. so we can use same constant for computing primary chan freq as 
> well. why switch to prim_chan_offset?

I think it'd be easier for drivers, since they typically seem to use
that to specify the control channel. If we give the frequency, they'll
have to calculate back to offset. The offset is also used in IEs etc.,
so I think overall that would simplify things.

johannes