Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Sam Leffler <sleffler@chromium.org>,
	Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH] iw: add lowpri and flush scan operands
Date: Tue, 16 Oct 2012 20:41:04 +0200	[thread overview]
Message-ID: <1350412864.10177.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1350346947-21280-1-git-send-email-bzhao@marvell.com>

On Mon, 2012-10-15 at 17:22 -0700, Bing Zhao wrote:

> --- a/nl80211.h
> +++ b/nl80211.h

No need to send nl80211.h updates, I do those directly by copying the
new file to avoid mismatch issues.


> -TOPLEVEL(scan, "[-u] [freq <freq>*] [ies <hex as 00:11:..>] [ssid <ssid>*|passive]", 0, 0,
> +TOPLEVEL(scan, "[-u] [freq <freq>*] [ies <hex as 00:11:..>] [ssid <ssid>*|passive|lowpri|flush]", 0, 0,

This seems a little wrong, you can't give lowpri/flush after giving
SSIDs, so it should probably be written as

... [ies <...>] [lowpri|flush] [ssid ...]

The SSID list has to be last since no keyword can terminate it
(everything could be a valid SSID)

>  	NL80211_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, handle_scan,
>  	 "Trigger a scan on the given frequencies with probing for the given\n"
> +

spurious newline?

johannes


  reply	other threads:[~2012-10-16 18:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  0:22 [PATCH] iw: add lowpri and flush scan operands Bing Zhao
2012-10-16 18:41 ` Johannes Berg [this message]
2012-10-16 19:43   ` Bing Zhao
2012-10-16 19:49     ` Johannes Berg
2012-10-16 20:01       ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350412864.10177.9.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=akarwar@marvell.com \
    --cc=bzhao@marvell.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sleffler@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox