From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: linville@tuxdriver.com, Javier Lopez <jlopex@cozybit.com>,
linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH] mac80211: Don't inspect Sequence Control field on control frames
Date: Thu, 25 Oct 2012 21:20:33 +0200 [thread overview]
Message-ID: <1351192833.10421.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAPjQAd9T5Ju3aEE1HeWT_5zLjW+rPQWkGQbh5Km9E1XunyFB9A@mail.gmail.com> (sfid-20121025_211316_966656_B5DA9711)
On Thu, 2012-10-25 at 12:12 -0700, Javier Cardona wrote:
> >> hdr = (struct ieee80211_hdr *)rx->skb->data;
> >> fc = hdr->frame_control;
> >> +
> >> + if (ieee80211_is_ctl(fc))
> >> + return RX_CONTINUE;
> >
> > Shouldn't that be "goto out"?
>
> If we goto out, we'll increment the rx_packets counter, which
> according to sta_info.h should only count MSDUs.
Ok.
> > And it seems it should also incorporate the skb->len check here, rather than accessing the field before checking
> > that it's present?
>
> ieee80211_rx_h_check() zaps all skbs with len < 16, so I don't think
> it's needed, no?
But the sequence control field is at offset 22, I think?
johannes
next prev parent reply other threads:[~2012-10-25 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 18:10 [PATCH] mac80211: Don't inspect Sequence Control field on control frames Javier Cardona
2012-10-25 18:48 ` Christian Lamparter
2012-10-25 19:03 ` Javier Cardona
2012-10-25 19:26 ` Christian Lamparter
2012-10-25 19:03 ` Johannes Berg
2012-10-25 19:12 ` Javier Cardona
2012-10-25 19:20 ` Johannes Berg [this message]
2012-10-25 19:43 ` Johannes Berg
2012-10-25 19:44 ` Javier Cardona
2012-10-25 19:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351192833.10421.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=jlopex@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox