From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac80211: verify that skb data is present
Date: Fri, 26 Oct 2012 12:21:34 +0200 [thread overview]
Message-ID: <1351246894.10813.10.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1351246782.10813.9.camel@jlt4.sipsolutions.net> (sfid-20121026_121912_401528_AD9E4EDC)
On Fri, 2012-10-26 at 12:19 +0200, Johannes Berg wrote:
> Ohh, ok, no I see, I'm not doing that. What we really need to do is
> something entirely different:
>
> if (is_multicast_ether_addr(hdr->addr1)) {
> mpp_addr = hdr->addr3;
> proxied_addr = mesh_hdr->eaddr1;
where this part is fine because the entire code is inside the AE check
already, so the eaddr1 must exist.
johannes
next prev parent reply other threads:[~2012-10-26 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 22:46 [PATCH 0/3] mac80211: audit for access to skb data Johannes Berg
2012-10-25 22:46 ` [PATCH 1/3] mac80211: check management frame header length Johannes Berg
2012-10-25 22:46 ` [PATCH 2/3] mac80211: verify that skb data is present Johannes Berg
2012-10-25 23:05 ` Thomas Pedersen
2012-10-25 23:58 ` Thomas Pedersen
2012-10-26 0:57 ` Thomas Pedersen
2012-10-26 10:19 ` Johannes Berg
2012-10-26 10:21 ` Johannes Berg [this message]
2012-10-26 11:00 ` [PATCH v2 " Johannes Berg
2012-10-26 16:29 ` Thomas Pedersen
2012-10-26 16:35 ` Johannes Berg
2012-10-25 22:46 ` [PATCH 3/3] mac80211: make sure data is accessible in EAPOL check Johannes Berg
2012-10-29 9:09 ` [PATCH 0/3] mac80211: audit for access to skb data Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351246894.10813.10.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).