From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: clear lower drv private data on iface removal
Date: Thu, 08 Nov 2012 13:43:22 +0100 [thread overview]
Message-ID: <1352378602.11421.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1352378241-31906-1-git-send-email-arik@wizery.com> (sfid-20121108_133740_044315_4BAB0F14)
On Thu, 2012-11-08 at 14:37 +0200, Arik Nemtsov wrote:
> The lower driver might rely on getting zeroed per-vif private memory
> when an interface is added. Resetting the memory on removal avoids
> adverse affects during recovery, where the interface is added without
> being removed.
However, it means that data isn't stable across suspend/resume, which
could be desirable to the driver as it may want to have the same
configuration after resuming.
I think we should therefore leave this to the driver, it's obviously
easily implemented as the last step of the driver's ->remove_interface()
johannes
next prev parent reply other threads:[~2012-11-08 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 12:37 [PATCH] mac80211: clear lower drv private data on iface removal Arik Nemtsov
2012-11-08 12:43 ` Johannes Berg [this message]
2012-11-08 12:43 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352378602.11421.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox