From: Johannes Berg <johannes@sipsolutions.net>
To: Marco Porsch <marco.porsch@etit.tu-chemnitz.de>
Cc: javier@cozybit.com, linux-wireless@vger.kernel.org,
Ivan Bezyazychnyy <ivan.bezyazychnyy@gmail.com>,
Mike Krinkin <krinkin.m.u@gmail.com>
Subject: Re: [RFC 03/14] {cfg,nl}80211: set and get default mesh power mode
Date: Sat, 17 Nov 2012 09:59:05 +0100 [thread overview]
Message-ID: <1353142745.9543.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1353134886-13256-4-git-send-email-marco.porsch@etit.tu-chemnitz.de>
On Fri, 2012-11-16 at 22:47 -0800, Marco Porsch wrote:
> Possibilities of setting and getting mesh default power mode are
> added.
ditto.
> + * @NL80211_MESHCONF_POWER_MODE: default link-specific power save
> mode
please describe the type of the attribute (u8)
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, power_mode,
> + mask, NL80211_MESHCONF_POWER_MODE,
> + nla_get_u8);
Huh, ok, how did this FILL_IN_MESH_PARAM thing ever get here ... sad I
missed that, all of those are *completely* missing range checks.
Please add them here, and somebody should also follow up with a patch to
fix them on the other attributes.
johannes
next prev parent reply other threads:[~2012-11-17 8:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 6:47 [RFC 00/14] mesh powersave - basics Marco Porsch
2012-11-17 6:47 ` [RFC 01/14] {nl,cfg,mac}80211: add beacon interval and DTIM period to mesh config Marco Porsch
2012-11-17 8:54 ` Johannes Berg
2012-11-17 6:47 ` [RFC 02/14] {cfg,nl}80211: mesh power mode config parameters Marco Porsch
2012-11-17 8:57 ` Johannes Berg
2012-11-17 6:47 ` [RFC 03/14] {cfg,nl}80211: set and get default mesh power mode Marco Porsch
2012-11-17 8:59 ` Johannes Berg [this message]
2012-11-17 23:38 ` Thomas Pedersen
2012-11-17 6:47 ` [RFC 04/14] mac80211: local link-specific mesh power mode logic Marco Porsch
2012-11-17 9:05 ` Johannes Berg
2012-11-17 6:47 ` [RFC 05/14] mac80211: mesh power mode indication in transmitted frames Marco Porsch
2012-11-17 9:10 ` Johannes Berg
2012-11-19 20:07 ` Marco Porsch
2012-11-19 20:32 ` Johannes Berg
2012-11-17 6:47 ` [RFC 06/14] mac80211: track neighbor STA power modes Marco Porsch
2012-11-17 9:14 ` Johannes Berg
2012-11-17 6:47 ` [RFC 07/14] {cfg,nl}80211: set local link-specific power mode Marco Porsch
2012-11-17 9:16 ` Johannes Berg
2012-11-17 6:48 ` [RFC 08/14] {cfg,nl}80211: get local and peer mesh power modes Marco Porsch
2012-11-17 6:48 ` [RFC 09/14] mac80211: add power save support structure to mesh interface Marco Porsch
2012-11-17 9:26 ` Johannes Berg
2012-11-20 23:53 ` Marco Porsch
2012-11-26 10:39 ` Johannes Berg
2012-11-17 6:48 ` [RFC 10/14] mac80211: enable frame buffering for PS STA Marco Porsch
2012-11-17 9:28 ` Johannes Berg
2012-11-17 6:48 ` [RFC 11/14] {cfg,nl}80211: add awake window to mesh config Marco Porsch
2012-11-17 9:29 ` Johannes Berg
2012-11-17 6:48 ` [RFC 12/14] mac80211: add awake window IE to mesh beacons Marco Porsch
2012-11-17 9:30 ` Johannes Berg
2012-11-17 6:48 ` [RFC 13/14] mac80211: add TIM " Marco Porsch
2012-11-17 9:33 ` Johannes Berg
2012-11-17 6:48 ` [RFC 14/14] mac80211: mesh PS individually-addressed frame release Marco Porsch
2012-11-17 9:40 ` Johannes Berg
2012-11-20 18:11 ` Marco Porsch
2012-11-26 10:45 ` Johannes Berg
2012-11-26 18:27 ` Marco Porsch
2012-11-28 13:07 ` Johannes Berg
2012-11-17 9:41 ` [RFC 00/14] mesh powersave - basics Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353142745.9543.9.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ivan.bezyazychnyy@gmail.com \
--cc=javier@cozybit.com \
--cc=krinkin.m.u@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=marco.porsch@etit.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).