From: Johannes Berg <johannes@sipsolutions.net>
To: Saravana <saravanad@posedge.com>
Cc: Julian Calaby <julian.calaby@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: RFC[1/2]mac80211: Add Statistic to debugfs
Date: Fri, 23 Nov 2012 08:11:56 +0100 [thread overview]
Message-ID: <1353654716.10197.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <50AF1A1E.8090704@posedge.com>
On Fri, 2012-11-23 at 12:09 +0530, Saravana wrote:
> > Also, as you're adding new statistics which are only used when debugfs
> > is enabled, you might want to wrap them in #ifdefs so that they're
> > only compiled when debugfs support is compiled.
[...]
> Hence we don't need to wrap this up in #ifdef as it is already taken
> care during the directory creation.
I think Julian is arguing that you should have the *counters* themselves
be under ifdef, and I tend to agree.
johannes
next prev parent reply other threads:[~2012-11-23 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:50 RFC[1/2]mac80211: Add Statistic to debugfs Saravana
2012-11-23 5:58 ` Julian Calaby
2012-11-23 6:39 ` Saravana
2012-11-23 6:53 ` Saravana
2012-11-23 7:11 ` Johannes Berg [this message]
2012-11-23 9:56 ` Saravana
2012-11-26 9:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353654716.10197.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=saravanad@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).